chore: remove usage of feature naming pattern flag (#5364)

In preparation for this feature going GA

frontend/src/component/feature/FeatureForm/FeatureForm.tsx

@@ -23,7 +23,6 @@ import React from 'react';
 import { useAuthPermissions } from 'hooks/api/getters/useAuth/useAuthPermissions';
 import { FeatureNamingType } from 'interfaces/project';
 import { FeatureNamingPatternInfo } from '../FeatureNamingPatternInfo/FeatureNamingPatternInfo';
-import { useUiFlag } from 'hooks/useUiFlag';
 
 interface IFeatureToggleForm {
     type: string;
@@ -122,15 +121,12 @@ const FeatureForm: React.FC<IFeatureToggleForm> = ({
     const navigate = useNavigate();
     const { permissions } = useAuthPermissions();
     const editable = mode !== 'Edit';
-    const featureNamingPatternEnabled = useUiFlag('featureNamingPattern');
 
     const renderToggleDescription = () => {
         return featureTypes.find((toggle) => toggle.id === type)?.description;
     };
 
-    const displayFeatureNamingInfo = Boolean(
+    const displayFeatureNamingInfo = Boolean(featureNaming?.pattern);
-        featureNamingPatternEnabled && featureNaming?.pattern,
-    );
 
     React.useEffect(() => {
         if (featureNaming?.pattern && validateToggleName && name) {

frontend/src/component/project/Project/ProjectEnterpriseSettingsForm/ProjectEnterpriseSettingsForm.tsx

@@ -136,7 +136,6 @@ const ProjectEnterpriseSettingsForm: React.FC<IProjectEnterpriseSettingsForm> =
         clearErrors,
     }) => {
         const privateProjects = useUiFlag('privateProjects');
-        const shouldShowFlagNaming = useUiFlag('featureNamingPattern');
 
         const { setPreviousPattern, trackPattern } =
             useFeatureNamePatternTracking();
@@ -253,9 +252,6 @@ const ProjectEnterpriseSettingsForm: React.FC<IProjectEnterpriseSettingsForm> =
                         options={projectModeOptions}
                     />
                 </>
-                <ConditionallyRender
-                    condition={Boolean(shouldShowFlagNaming)}
-                    show={
                 <StyledFieldset>
                     <Box
                         sx={{
@@ -279,14 +275,14 @@ const ProjectEnterpriseSettingsForm: React.FC<IProjectEnterpriseSettingsForm> =
                                 >
                                     JavaScript RegEx
                                 </a>{' '}
-                                        used to enforce feature flag names
+                                used to enforce feature flag names within this
-                                        within this project. The regex will be
+                                project. The regex will be surrounded by a
-                                        surrounded by a leading <code>^</code>{' '}
+                                leading <code>^</code> and a trailing{' '}
-                                        and a trailing <code>$</code>.
+                                <code>$</code>.
                             </p>
                             <p>
-                                        Leave it empty if you don’t want to add
+                                Leave it empty if you don’t want to add a naming
-                                        a naming pattern.
+                                pattern.
                             </p>
                         </StyledPatternNamingExplanation>
                     </StyledSubtitle>
@@ -313,16 +309,14 @@ const ProjectEnterpriseSettingsForm: React.FC<IProjectEnterpriseSettingsForm> =
                             error={Boolean(errors.featureNamingPattern)}
                             errorText={errors.featureNamingPattern}
                             onChange={(e) =>
-                                        onSetFeatureNamingPattern(
+                                onSetFeatureNamingPattern(e.target.value)
-                                            e.target.value,
-                                        )
                             }
                         />
                         <StyledSubtitle>
                             <p id='pattern-additional-description'>
-                                        The example and description will be
+                                The example and description will be shown to
-                                        shown to users when they create a new
+                                users when they create a new feature flag in
-                                        feature flag in this project.
+                                this project.
                             </p>
                         </StyledSubtitle>
 
@@ -336,9 +330,7 @@ const ProjectEnterpriseSettingsForm: React.FC<IProjectEnterpriseSettingsForm> =
                             error={Boolean(errors.namingExample)}
                             errorText={errors.namingExample}
                             onChange={(e) =>
-                                        onSetFeatureNamingExample(
+                                onSetFeatureNamingExample(e.target.value)
-                                            e.target.value,
-                                        )
                             }
                         />
                         <StyledTextField
@@ -353,15 +345,11 @@ The flag name should contain the project name, the feature name, and the ticket
                             minRows={5}
                             value={featureNamingDescription || ''}
                             onChange={(e) =>
-                                        onSetFeatureNamingDescription(
+                                onSetFeatureNamingDescription(e.target.value)
-                                            e.target.value,
-                                        )
                             }
                         />
                     </StyledFlagNamingContainer>
                 </StyledFieldset>
-                    }
-                />
                 <StyledButtonContainer>{children}</StyledButtonContainer>
             </StyledForm>
         );

frontend/src/interfaces/uiConfig.ts

@@ -61,7 +61,6 @@ export type UiFlags = {
     customRootRolesKillSwitch?: boolean;
     strategyVariant?: boolean;
     lastSeenByEnvironment?: boolean;
-    featureNamingPattern?: boolean;
     doraMetrics?: boolean;
     variantTypeNumber?: boolean;
     privateProjects?: boolean;

src/lib/__snapshots__/create-config.test.ts.snap

@@ -84,7 +84,6 @@ exports[`should create default config 1`] = `
       "doraMetrics": false,
       "embedProxy": true,
       "embedProxyFrontend": true,
-      "featureNamingPattern": false,
       "featureSearchAPI": false,
       "featureSearchFrontend": false,
       "featuresExportImport": true,

src/lib/features/export-import-toggles/export-import.e2e.test.ts

@@ -159,7 +159,6 @@ beforeAll(async () => {
             experimental: {
                 flags: {
                     featuresExportImport: true,
-                    featureNamingPattern: true,
                     dependentFeatures: true,
                 },
             },

src/lib/features/feature-toggle/feature-toggle-service.ts

@@ -1168,7 +1168,6 @@ class FeatureToggleService {
         projectId: string,
         featureNames: string[],
     ): Promise<FeatureNameCheckResultWithFeaturePattern> {
-        if (this.flagResolver.isEnabled('featureNamingPattern')) {
         const project = await this.projectStore.get(projectId);
         const patternData = project.featureNaming;
         const namingPattern = patternData?.pattern;
@@ -1183,7 +1182,7 @@ class FeatureToggleService {
                 return { ...result, featureNaming: patternData };
             }
         }
-        }
+
         return { state: 'valid' };
     }
 

src/lib/features/feature-toggle/tests/feature-toggle-service.e2e.test.ts

@@ -39,7 +39,7 @@ const irrelevantDate = new Date();
 beforeAll(async () => {
     const config = createTestConfig({
         experimental: {
-            flags: { featureNamingPattern: true, playgroundImprovements: true },
+            flags: { playgroundImprovements: true },
         },
     });
     db = await dbInit(

src/lib/types/experimental.ts

@@ -23,7 +23,6 @@ export type IFlagKey =
     | 'filterInvalidClientMetrics'
     | 'lastSeenByEnvironment'
     | 'customRootRolesKillSwitch'
-    | 'featureNamingPattern'
     | 'doraMetrics'
     | 'variantTypeNumber'
     | 'privateProjects'
@@ -116,10 +115,6 @@ const flags: IFlags = {
         process.env.UNLEASH_EXPERIMENTAL_CUSTOM_ROOT_ROLES_KILL_SWITCH,
         false,
     ),
-    featureNamingPattern: parseEnvVarBoolean(
-        process.env.UNLEASH_EXPERIMENTAL_FEATURE_NAMING_PATTERN,
-        false,
-    ),
     doraMetrics: parseEnvVarBoolean(
         process.env.UNLEASH_EXPERIMENTAL_DORA_METRICS,
         false,

src/server-dev.ts

@@ -38,7 +38,6 @@ process.nextTick(async () => {
                         anonymiseEventLog: false,
                         responseTimeWithAppNameKillSwitch: false,
                         lastSeenByEnvironment: true,
-                        featureNamingPattern: true,
                         doraMetrics: true,
                         variantTypeNumber: true,
                         privateProjects: true,

src/test/e2e/api/client/feature.e2e.test.ts

@@ -21,7 +21,6 @@ beforeAll(async () => {
             experimental: {
                 flags: {
                     strictSchemaValidation: true,
-                    featureNamingPattern: true,
                     dependentFeatures: true,
                 },
             },