chore: remove scheduledConfigurationChanges flag (#6360)

What is says on the box

---------

Signed-off-by: andreas-unleash <andreas@getunleash.ai>

frontend/src/component/changeRequest/ChangeRequest/ChangeRequest.test.tsx

@@ -18,9 +18,6 @@ const uiConfigForEnterprise = () =>
         versionInfo: {
             current: { oss: 'version', enterprise: 'version' },
         },
-        flags: {
-            scheduledConfigurationChanges: true,
-        },
     });
 
 const featureWithStrategyVariants = () =>

frontend/src/component/changeRequest/ChangeRequestOverview/ChangeRequestOverview.test.tsx

@@ -142,9 +142,6 @@ const uiConfig = () => {
         versionInfo: {
             current: { oss: 'version', enterprise: 'version' },
         },
-        flags: {
-            scheduledConfigurationChanges: true,
-        },
     });
 };
 

frontend/src/component/changeRequest/ChangeRequestOverview/ChangeRequestOverview.tsx

@@ -28,7 +28,6 @@ import { changesCount } from '../changesCount';
 import { ChangeRequestReviewers } from './ChangeRequestReviewers/ChangeRequestReviewers';
 import { ChangeRequestRejectDialogue } from './ChangeRequestRejectDialog/ChangeRequestRejectDialog';
 import { ApplyButton } from './ApplyButton/ApplyButton';
-import { useUiFlag } from 'hooks/useUiFlag';
 import {
     ChangeRequestApplyScheduledDialogue,
     ChangeRequestRejectScheduledDialogue,
@@ -103,7 +102,6 @@ export const ChangeRequestOverview: FC = () => {
     const { setToastData, setToastApiError } = useToast();
     const { isChangeRequestConfiguredForReview } =
         useChangeRequestsEnabled(projectId);
-    const scheduleChangeRequests = useUiFlag('scheduledConfigurationChanges');
     const [disabled, setDisabled] = useState(false);
 
     if (!changeRequest) {
@@ -382,9 +380,6 @@ export const ChangeRequestOverview: FC = () => {
                             />
                             <ConditionallyRender
                                 condition={changeRequest.state === 'Approved'}
-                                show={
-                                    <ConditionallyRender
-                                        condition={scheduleChangeRequests}
                                 show={
                                     <ApplyButton
                                         onApply={onApplyChanges}
@@ -393,41 +388,15 @@ export const ChangeRequestOverview: FC = () => {
                                             disabled
                                         }
                                         onSchedule={() =>
-                                                    setShowScheduleChangeDialog(
+                                            setShowScheduleChangeDialog(true)
-                                                        true,
-                                                    )
                                         }
                                     >
                                         Apply or schedule changes
                                     </ApplyButton>
                                 }
-                                        elseShow={
-                                            <PermissionButton
-                                                variant='contained'
-                                                onClick={onApplyChanges}
-                                                projectId={projectId}
-                                                permission={
-                                                    APPLY_CHANGE_REQUEST
-                                                }
-                                                environmentId={
-                                                    changeRequest.environment
-                                                }
-                                                disabled={
-                                                    !allowChangeRequestActions ||
-                                                    disabled
-                                                }
-                                            >
-                                                Apply changes
-                                            </PermissionButton>
-                                        }
-                                    />
-                                }
                             />
                             <ConditionallyRender
-                                condition={
+                                condition={changeRequest.state === 'Scheduled'}
-                                    scheduleChangeRequests &&
-                                    changeRequest.state === 'Scheduled'
-                                }
                                 show={
                                     <ApplyButton
                                         onApply={() =>
@@ -457,10 +426,7 @@ export const ChangeRequestOverview: FC = () => {
                                 }
                                 show={
                                     <ConditionallyRender
-                                        condition={
+                                        condition={Boolean(scheduledAt)}
-                                            scheduleChangeRequests &&
-                                            Boolean(scheduledAt)
-                                        }
                                         show={
                                             <StyledButton
                                                 variant='outlined'
@@ -513,17 +479,12 @@ export const ChangeRequestOverview: FC = () => {
                     onClose={onCancelReject}
                     disabled={disabled}
                 />
-                <ConditionallyRender
-                    condition={scheduleChangeRequests}
-                    show={
                 <>
                     <ScheduleChangeRequestDialog
                         open={showScheduleChangesDialog}
                         onConfirm={onScheduleChangeRequest}
                         onClose={onScheduleChangeAbort}
-                                disabled={
+                        disabled={!allowChangeRequestActions || disabled}
-                                    !allowChangeRequestActions || disabled
-                                }
                         projectId={projectId}
                         environment={changeRequest.environment}
                         primaryButtonText={
@@ -543,9 +504,7 @@ export const ChangeRequestOverview: FC = () => {
                         onConfirm={onApplyChanges}
                         onClose={onApplyScheduledAbort}
                         scheduledTime={scheduledAt}
-                                disabled={
+                        disabled={!allowChangeRequestActions || disabled}
-                                    !allowChangeRequestActions || disabled
-                                }
                         projectId={projectId}
                         environment={changeRequest.environment}
                     />
@@ -557,8 +516,6 @@ export const ChangeRequestOverview: FC = () => {
                         disabled={disabled}
                     />
                 </>
-                    }
-                />
             </ChangeRequestBody>
         </>
     );

frontend/src/component/feature/FeatureView/FeatureOverview/FeatureOverviewEnvironments/FeatureOverviewEnvironment/EnvironmentAccordionBody/StrategyDraggableItem/StrategyDraggableItem.test.tsx

@@ -100,9 +100,6 @@ const uiConfig = () => {
         versionInfo: {
             current: { oss: 'version', enterprise: 'version' },
         },
-        flags: {
-            scheduledConfigurationChanges: true,
-        },
     });
 };
 

frontend/src/component/feature/FeatureView/FeatureVariants/FeatureEnvironmentVariants/EnvironmentVariantsCard/EnvironmentVariantsCard.test.tsx

@@ -93,9 +93,6 @@ const uiConfig = () => {
         versionInfo: {
             current: { oss: 'version', enterprise: 'version' },
         },
-        flags: {
-            scheduledConfigurationChanges: true,
-        },
     });
 };
 

frontend/src/component/project/Project/ProjectSettings/ChangeRequestConfiguration/ChangeRequestProcessHelp/ChangeRequestProcessHelp.tsx

@@ -21,9 +21,6 @@ export const ChangeRequestProcessHelp: VFC<IChangeRequestProcessHelpProps> =
         const theme = useTheme();
         const isSmallScreen = useMediaQuery(theme.breakpoints.down('md'));
         const [isOpen, setIsOpen] = useState(false);
-        const showScheduleInformation = useUiFlag(
-            'scheduledConfigurationChanges',
-        );
 
         const descriptionId = 'change-request-process-description';
 
@@ -96,113 +93,71 @@ export const ChangeRequestProcessHelp: VFC<IChangeRequestProcessHelpProps> =
                                         </li>
                                     </ul>
                                 </li>
-                                <ConditionallyRender
-                                    condition={showScheduleInformation}
-                                    show={
                                 <>
                                     <li>
                                         Once approved, a user with the{' '}
                                         <strong>
-                                                    “Apply/Reject change
+                                            “Apply/Reject change request”
-                                                    request”
                                         </strong>{' '}
-                                                permission can apply, schedule,
+                                        permission can apply, schedule, or
-                                                or reject the changes.
+                                        reject the changes.
                                         <ul>
                                             <li>
-                                                        If applied, the changes
+                                                If applied, the changes will
-                                                        will take effect and the
+                                                take effect and the change
-                                                        change request will be
+                                                request will be closed.
-                                                        closed.
                                             </li>
                                             <li>
-                                                        If scheduled, Unleash
+                                                If scheduled, Unleash will
-                                                        will attempt to apply
+                                                attempt to apply the changes at
-                                                        the changes at the
+                                                the scheduled date and time.
-                                                        scheduled date and time.
                                             </li>
                                             <li>
-                                                        The user who created the
+                                                The user who created the change
-                                                        change request can
+                                                request can cancel the changes
-                                                        cancel the changes up
+                                                up until they are applied or
-                                                        until they are applied
+                                                scheduled.
-                                                        or scheduled.
                                             </li>
                                         </ul>
                                     </li>
                                     <li>
                                         A user with the{' '}
                                         <strong>
-                                                    “Apply/Reject change
+                                            “Apply/Reject change request”
-                                                    request”
                                         </strong>{' '}
-                                                permission can reschedule,
+                                        permission can reschedule, reject, or
-                                                reject, or immediately apply a
+                                        immediately apply a scheduled change
-                                                scheduled change request.
+                                        request.
                                         <ul>
                                             <li>
                                                 If any of the flags or
-                                                        strategies in the change
+                                                strategies in the change request
-                                                        request are archived or
+                                                are archived or deleted (outside
-                                                        deleted (outside of the
+                                                of the change request), thus
-                                                        change request), thus
+                                                creating a conflict, Unleash
-                                                        creating a conflict,
+                                                will send an email out to the
-                                                        Unleash will send an
+                                                change request author and to the
-                                                        email out to the change
+                                                user who (last) scheduled the
-                                                        request author and to
+                                                change request.
-                                                        the user who (last)
-                                                        scheduled the change
-                                                        request.
                                             </li>
                                             <li>
-                                                        If the scheduled changes
+                                                If the scheduled changes contain
-                                                        contain any conflicts,
+                                                any conflicts, Unleash will
-                                                        Unleash will refuse to
+                                                refuse to apply them.
-                                                        apply them.
                                             </li>
                                             <li>
-                                                        If the user who
+                                                If the user who scheduled the
-                                                        scheduled the changes is
+                                                changes is removed from this
-                                                        removed from this
+                                                Unleash instance, the scheduled
-                                                        Unleash instance, the
+                                                changes will also not be
-                                                        scheduled changes will
+                                                applied.
-                                                        also not be applied.
                                             </li>
                                         </ul>
                                     </li>
                                 </>
-                                    }
-                                    elseShow={
-                                        <li>
-                                            Once approved, a user with the{' '}
-                                            <strong>
-                                                “Apply/Reject change request”
-                                            </strong>{' '}
-                                            permission can apply or reject the
-                                            changes.
-                                            <ul>
-                                                <li>
-                                                    Once applied, the changes
-                                                    will take effect and the
-                                                    change request will be
-                                                    closed.
-                                                </li>
-                                                <li>
-                                                    The user who created the
-                                                    change request can cancel
-                                                    the changes up until they
-                                                    are applied.
-                                                </li>
-                                            </ul>
-                                        </li>
-                                    }
-                                />
                             </ol>
                         </Typography>
                         <Box sx={{ mt: 3 }}>
-                            <ConditionallyRender
-                                condition={showScheduleInformation}
-                                show={
                             <ChangeRequestProcessWithScheduleImage
                                 aria-details={descriptionId}
                                 style={{
@@ -210,16 +165,6 @@ export const ChangeRequestProcessHelp: VFC<IChangeRequestProcessHelpProps> =
                                     height: 'auto',
                                 }}
                             />
-                                }
-                                elseShow={
-                                    <ChangeRequestProcessImage
-                                        aria-details={descriptionId}
-                                        style={{
-                                            maxWidth: 'calc(100vw - 4rem)',
-                                        }}
-                                    />
-                                }
-                            />
                         </Box>
                     </Box>
                 </Popover>

frontend/src/interfaces/uiConfig.ts

@@ -62,7 +62,6 @@ export type UiFlags = {
     strategyVariant?: boolean;
     doraMetrics?: boolean;
     dependentFeatures?: boolean;
-    scheduledConfigurationChanges?: boolean;
     newStrategyConfiguration?: boolean;
     incomingWebhooks?: boolean;
     automatedActions?: boolean;

src/lib/__snapshots__/create-config.test.ts.snap

@@ -133,7 +133,6 @@ exports[`should create default config 1`] = `
       "personalAccessTokensKillSwitch": false,
       "proPlanAutoCharge": false,
       "responseTimeWithAppNameKillSwitch": false,
-      "scheduledConfigurationChanges": false,
       "scimApi": false,
       "sdkReporting": false,
       "showInactiveUsers": false,

src/lib/types/experimental.ts

@@ -26,7 +26,6 @@ export type IFlagKey =
     | 'advancedPlayground'
     | 'filterInvalidClientMetrics'
     | 'disableMetrics'
-    | 'scheduledConfigurationChanges'
     | 'stripClientHeadersOn304'
     | 'stripHeadersOnAPI'
     | 'incomingWebhooks'
@@ -130,10 +129,6 @@ const flags: IFlags = {
         process.env.UNLEASH_EXPERIMENTAL_DISABLE_METRICS,
         false,
     ),
-    scheduledConfigurationChanges: parseEnvVarBoolean(
-        process.env.UNLEASH_EXPERIMENTAL_SCHEDULED_CONFIGURATION_CHANGES,
-        false,
-    ),
     stripClientHeadersOn304: parseEnvVarBoolean(
         process.env
             .UNLEASH_EXPERIMENTAL_DETECT_SEGMENT_USAGE_IN_CHANGE_REQUESTS,