diff --git a/src/lib/routes/admin-api/config.test.ts b/src/lib/routes/admin-api/config.test.ts index 4038c069ca..94547dada8 100644 --- a/src/lib/routes/admin-api/config.test.ts +++ b/src/lib/routes/admin-api/config.test.ts @@ -99,16 +99,16 @@ describe('displayUpgradeEdgeBanner', () => { }); }); -describe('displayFeatureEnvironmentVariants', () => { - test('ui config should have displayFeatureEnvironmentVariants flag disabled if no env variants are used', async () => { +describe('hideFeatureEnvironmentVariants', () => { + test('ui config should have hideFeatureEnvironmentVariants flag enabled if no env variants are used', async () => { const { body } = await request .get(`${base}/api/admin/ui-config`) .expect('Content-Type', /json/) .expect(200); expect(body.flags).toBeTruthy(); - expect(body.flags.displayFeatureEnvironmentVariants).toEqual(false); + expect(body.flags.hideFeatureEnvironmentVariants).toEqual(true); }); - test('ui config should have displayFeatureEnvironmentVariants flag enabled if env variants are used', async () => { + test('ui config should have hideFeatureEnvironmentVariants flag disabled if env variants are used', async () => { await stores.featureEnvironmentStore.addEnvironmentToFeature( 'test', 'default', @@ -131,6 +131,6 @@ describe('displayFeatureEnvironmentVariants', () => { .expect('Content-Type', /json/) .expect(200); expect(body.flags).toBeTruthy(); - expect(body.flags.displayFeatureEnvironmentVariants).toEqual(true); + expect(body.flags.hideFeatureEnvironmentVariants).toEqual(false); }); }); diff --git a/src/lib/routes/admin-api/config.ts b/src/lib/routes/admin-api/config.ts index ec54fd4b08..e9a548cbcf 100644 --- a/src/lib/routes/admin-api/config.ts +++ b/src/lib/routes/admin-api/config.ts @@ -167,7 +167,7 @@ class ConfigController extends Controller { displayUpgradeEdgeBanner: usesOldEdge || this.config.flagResolver.isEnabled('displayEdgeBanner'), - displayFeatureEnvironmentVariants: usesFeatureEnvironmentVariants, + hideFeatureEnvironmentVariants: !usesFeatureEnvironmentVariants, }; const response: UiConfigSchema = { diff --git a/src/test/e2e/api/admin/config.e2e.test.ts b/src/test/e2e/api/admin/config.e2e.test.ts index 55cd3399d1..fd8bd330a2 100644 --- a/src/test/e2e/api/admin/config.e2e.test.ts +++ b/src/test/e2e/api/admin/config.e2e.test.ts @@ -99,11 +99,11 @@ test('sets ui config with frontendSettings', async () => { ); }); -test('ui config should have displayFeatureEnvironmentVariants flag disabled if no env variants are used', async () => { +test('ui config should have hideFeatureEnvironmentVariants flag enabled if no env variants are used', async () => { const { body } = await app.request .get('/api/admin/ui-config') .expect('Content-Type', /json/) .expect(200); expect(body.flags).toBeTruthy(); - expect(body.flags.displayFeatureEnvironmentVariants).toEqual(false); + expect(body.flags.hideFeatureEnvironmentVariants).toEqual(true); });