Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-01-11 00:08:30 +01:00
Code Issues Projects Releases Wiki Activity

fix: isPro check on change request configuration (#2610)

Browse Source 
https://linear.app/unleash/issue/2-487/bug-change-request-badge-is-not-working-on-pro
Using the new `isPro()` from `useUiConfig()` seems to fix this in Pro,
correctly showing the premium feature info:


![image](https://user-images.githubusercontent.com/14320932/205958034-f412471a-c732-425a-bb14-64b62ea1e665.png)

The errors described in the issue should be fixed by the new
`useEnterpriseSWR`. See:
https://unleash-internal.slack.com/archives/C046LV6HH6W/p1670337216187539?thread_ts=1670331887.521059&cid=C046LV6HH6W
This commit is contained in:
Nuno Góis 2022-12-07 10:23:19 +00:00 committed by GitHub
parent 9accbcfa8b
commit 990b708632
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
frontend/src/component/project/Project/ProjectSettings/ChangeRequestConfiguration/ChangeRequestConfiguration.tsx
View File

@ -23,14 +23,11 @@ export const ChangeRequestConfiguration = () => {
const projectId = useRequiredPathParam('projectId');
const projectName = useProjectNameOrId(projectId);
const { hasAccess } = useContext(AccessContext);
const { isOss, uiConfig } = useUiConfig();
const isPro = !(
Boolean(uiConfig.versionInfo?.current.oss) ||
Boolean(uiConfig.versionInfo?.current.enterprise)
);
const { isOss, isPro } = useUiConfig();
usePageTitle(`Project change request – ${projectName}`);
if (isOss() || isPro) {
if (isOss() || isPro()) {
return (
<PageContent
header={<PageHeader title="Change request configuration" />}