Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-02-14 00:19:16 +01:00
Code Issues Projects Releases Wiki Activity

fix: tags endpoint returning 404 when featureId is not set (#2621)

Browse Source 
Leverages the new `useConditionalSWR` hook to fix the underlying issue
in the `useTags` hook, preventing edge cases where we try to fetch when
featureId is not correctly set.
This commit is contained in:
Nuno Góis 2022-12-08 11:16:53 +00:00 committed by GitHub
parent 739b6c3170
commit 9b10b26ba4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
frontend/src/hooks/api/getters/useTags/useTags.ts
View File

@ -1,8 +1,9 @@
import useSWR, { mutate, SWRConfiguration } from 'swr'; import { mutate, SWRConfiguration } from 'swr';
import { useState, useEffect } from 'react'; import { useState, useEffect } from 'react';
import { formatApiPath } from 'utils/formatPath'; import { formatApiPath } from 'utils/formatPath';
import { ITag } from 'interfaces/tags'; import { ITag } from 'interfaces/tags';
import handleErrorResponses from '../httpErrorResponseHandler'; import handleErrorResponses from '../httpErrorResponseHandler';
import { useConditionalSWR } from '../useConditionalSWR/useConditionalSWR';
const useTags = (featureId: string, options: SWRConfiguration = {}) => { const useTags = (featureId: string, options: SWRConfiguration = {}) => {
const fetcher = async () => { const fetcher = async () => {
@ -15,7 +16,13 @@ const useTags = (featureId: string, options: SWRConfiguration = {}) => {
const KEY = `api/admin/features/${featureId}/tags`; const KEY = `api/admin/features/${featureId}/tags`;
const { data, error } = useSWR(KEY, fetcher, options); const { data, error } = useConditionalSWR<{ tags: ITag[] }>(
Boolean(featureId),
{ tags: [] },
KEY,
fetcher,
options
);
const [loading, setLoading] = useState(!error && !data); const [loading, setLoading] = useState(!error && !data);
const refetch = () => { const refetch = () => {