1
0
mirror of https://github.com/Unleash/unleash.git synced 2025-05-12 01:17:04 +02:00

fix: missing page titles (#8477)

This commit is contained in:
Mateusz Kwasniewski 2024-10-18 13:12:58 +02:00 committed by GitHub
parent a9f9be1efa
commit 9b3529d7cb
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
6 changed files with 14 additions and 17 deletions

View File

@ -12,6 +12,7 @@ import { ADMIN } from '@server/types/permissions';
import { PremiumFeature } from 'component/common/PremiumFeature/PremiumFeature'; import { PremiumFeature } from 'component/common/PremiumFeature/PremiumFeature';
import { useState } from 'react'; import { useState } from 'react';
import { TabPanel } from 'component/common/TabNav/TabPanel/TabPanel'; import { TabPanel } from 'component/common/TabNav/TabPanel/TabPanel';
import { usePageTitle } from 'hooks/usePageTitle';
export const AuthSettings = () => { export const AuthSettings = () => {
const { authenticationType } = useUiConfig().uiConfig; const { authenticationType } = useUiConfig().uiConfig;
@ -46,6 +47,7 @@ export const AuthSettings = () => {
} }
const [activeTab, setActiveTab] = useState(0); const [activeTab, setActiveTab] = useState(0);
usePageTitle(`Single sign-on: ${tabs[activeTab].label}`);
return ( return (
<div> <div>

View File

@ -14,6 +14,7 @@ import Add from '@mui/icons-material/Add';
import ResponsiveButton from 'component/common/ResponsiveButton/ResponsiveButton'; import ResponsiveButton from 'component/common/ResponsiveButton/ResponsiveButton';
import type { IRole } from 'interfaces/role'; import type { IRole } from 'interfaces/role';
import { TabLink } from 'component/common/TabNav/TabLink'; import { TabLink } from 'component/common/TabNav/TabLink';
import { usePageTitle } from 'hooks/usePageTitle';
const StyledHeader = styled('div')(() => ({ const StyledHeader = styled('div')(() => ({
display: 'flex', display: 'flex',
@ -31,6 +32,7 @@ const StyledActions = styled('div')({
}); });
export const RolesPage = () => { export const RolesPage = () => {
usePageTitle('Roles');
const { pathname } = useLocation(); const { pathname } = useLocation();
const { roles, projectRoles, loading } = useRoles(); const { roles, projectRoles, loading } = useRoles();

View File

@ -5,7 +5,7 @@ import { sortTypes } from 'utils/sortTypes';
import { PageContent } from 'component/common/PageContent/PageContent'; import { PageContent } from 'component/common/PageContent/PageContent';
import useFeatureTypes from 'hooks/api/getters/useFeatureTypes/useFeatureTypes'; import useFeatureTypes from 'hooks/api/getters/useFeatureTypes/useFeatureTypes';
import { PageHeader } from 'component/common/PageHeader/PageHeader'; import { PageHeader } from 'component/common/PageHeader/PageHeader';
import { Box, Typography } from '@mui/material'; import { Box } from '@mui/material';
import { import {
Table, Table,
TableBody, TableBody,
@ -150,18 +150,7 @@ export const FeatureTypesList = () => {
return ( return (
<PageContent <PageContent
isLoading={loading} isLoading={loading}
header={ header={<PageHeader title='Feature flag types' />}
<PageHeader>
<Typography
component='h2'
sx={(theme) => ({
fontSize: theme.fontSizes.mainHeader,
})}
>
Feature flag types
</Typography>
</PageHeader>
}
> >
<Table {...getTableProps()}> <Table {...getTableProps()}>
<SortableTableHeader headerGroups={headerGroups} /> <SortableTableHeader headerGroups={headerGroups} />

View File

@ -69,6 +69,7 @@ export const InsightsHeader: VFC<DashboardHeaderProps> = ({ actions }) => {
return ( return (
<> <>
<PageHeader <PageHeader
title='Insights'
titleElement={ titleElement={
<Typography <Typography
variant='h1' variant='h1'

View File

@ -19,6 +19,7 @@ import useSplashApi from 'hooks/api/actions/useSplashApi/useSplashApi';
import { useAuthSplash } from 'hooks/api/getters/useAuth/useAuthSplash'; import { useAuthSplash } from 'hooks/api/getters/useAuth/useAuthSplash';
import { useDashboardState } from './useDashboardState'; import { useDashboardState } from './useDashboardState';
import { MyFlags } from './MyFlags'; import { MyFlags } from './MyFlags';
import { usePageTitle } from 'hooks/usePageTitle';
const WelcomeSection = styled('div')(({ theme }) => ({ const WelcomeSection = styled('div')(({ theme }) => ({
display: 'flex', display: 'flex',
@ -103,9 +104,10 @@ export const PersonalDashboard = () => {
const { trackEvent } = usePlausibleTracker(); const { trackEvent } = usePlausibleTracker();
const { setSplashSeen } = useSplashApi(); const { setSplashSeen } = useSplashApi();
const { splash } = useAuthSplash(); const { splash } = useAuthSplash();
const name = user?.name; const name = user?.name;
usePageTitle(`Dashboard: ${name}`);
const { personalDashboard, refetch: refetchDashboard } = const { personalDashboard, refetch: refetchDashboard } =
usePersonalDashboard(); usePersonalDashboard();

View File

@ -397,9 +397,10 @@ export const StrategiesList = () => {
<PageContent <PageContent
isLoading={loading} isLoading={loading}
header={ header={
<PageHeader> <PageHeader
<PredefinedStrategyTitle /> titleElement={<PredefinedStrategyTitle />}
</PageHeader> title='Strategy types'
/>
} }
> >
<Box> <Box>