From 9bf5ed50749b548a074b29111bff82cd689d1cc9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gast=C3=B3n=20Fournier?= <gaston@getunleash.io>
Date: Tue, 15 Oct 2024 11:29:33 +0200
Subject: [PATCH] fix: move event listeners outside metric collection

---
 src/lib/metrics.ts | 45 +++++++++++++++++++++------------------------
 1 file changed, 21 insertions(+), 24 deletions(-)

diff --git a/src/lib/metrics.ts b/src/lib/metrics.ts
index 6d08ffde5c..9a77755931 100644
--- a/src/lib/metrics.ts
+++ b/src/lib/metrics.ts
@@ -460,30 +460,6 @@ export default class MetricsMonitor {
                         .set(stage.duration);
                 });
 
-                eventBus.on(
-                    events.STAGE_ENTERED,
-                    (entered: { stage: string; feature: string }) => {
-                        if (flagResolver.isEnabled('trackLifecycleMetrics')) {
-                            logger.info(
-                                `STAGE_ENTERED listened ${JSON.stringify(entered)}`,
-                            );
-                        }
-                        featureLifecycleStageEnteredCounter.increment({
-                            stage: entered.stage,
-                        });
-                    },
-                );
-
-                eventBus.on(
-                    events.EXCEEDS_LIMIT,
-                    ({
-                        resource,
-                        limit,
-                    }: { resource: string; limit: number }) => {
-                        exceedsLimitErrorCounter.increment({ resource, limit });
-                    },
-                );
-
                 featureLifecycleStageCountByProject.reset();
                 stageCountByProjectResult.forEach((stageResult) =>
                     featureLifecycleStageCountByProject
@@ -723,6 +699,27 @@ export default class MetricsMonitor {
             0, // no jitter
         );
 
+        eventBus.on(
+            events.EXCEEDS_LIMIT,
+            ({ resource, limit }: { resource: string; limit: number }) => {
+                exceedsLimitErrorCounter.increment({ resource, limit });
+            },
+        );
+
+        eventBus.on(
+            events.STAGE_ENTERED,
+            (entered: { stage: string; feature: string }) => {
+                if (flagResolver.isEnabled('trackLifecycleMetrics')) {
+                    logger.info(
+                        `STAGE_ENTERED listened ${JSON.stringify(entered)}`,
+                    );
+                }
+                featureLifecycleStageEnteredCounter.increment({
+                    stage: entered.stage,
+                });
+            },
+        );
+
         eventBus.on(
             events.REQUEST_TIME,
             ({ path, method, time, statusCode, appName }) => {