1
0
mirror of https://github.com/Unleash/unleash.git synced 2025-08-13 13:48:59 +02:00

more moving

This commit is contained in:
Thomas Heartman 2025-05-07 08:49:15 +02:00
parent ee0a453cc9
commit 9ded99f964
3 changed files with 4 additions and 18 deletions

View File

@ -153,10 +153,6 @@ export const NewConstraintAccordionList = forwardRef<
constraint={constraint}
onCancel={onCancel?.bind(null, index)}
onDelete={onRemove?.bind(null, index)}
onSave={onSave!.bind(null, index)}
onAutoSave={onAutoSave?.(
constraint[constraintId],
)}
/>
) : (
<ConstraintAccordionView

View File

@ -176,7 +176,6 @@ const getInputType = (input: Input): InputType => {
};
type Props = {
constraint: IConstraint;
localConstraint: IConstraint;
setContextName: (contextName: string) => void;
setOperator: (operator: Operator) => void;
@ -184,26 +183,20 @@ type Props = {
onDelete?: () => void;
toggleInvertedOperator: () => void;
toggleCaseSensitivity: () => void;
onUndo: () => void;
constraintChanges: IConstraint[];
contextDefinition: Pick<IUnleashContextDefinition, 'legalValues'>;
constraintValues: string[];
constraintValue: string;
setValue: (value: string) => void;
setValues: (values: string[]) => void;
setValuesWithRecord: (values: string[]) => void;
removeValue: (index: number) => void;
};
export const EditableConstraint: FC<Props> = ({
constraintChanges,
constraint,
localConstraint,
setLocalConstraint,
setContextName,
setOperator,
onDelete,
onUndo,
toggleInvertedOperator,
toggleCaseSensitivity,
contextDefinition,
@ -211,7 +204,6 @@ export const EditableConstraint: FC<Props> = ({
constraintValue,
setValue,
setValues,
setValuesWithRecord,
removeValue,
}) => {
const { input } = useConstraintInput({
@ -324,7 +316,7 @@ export const EditableConstraint: FC<Props> = ({
...(localConstraint.values || []),
...newValues,
]);
setValuesWithRecord(Array.from(combinedValues));
setValues(Array.from(combinedValues));
}}
/>
);
@ -399,7 +391,7 @@ export const EditableConstraint: FC<Props> = ({
<ValueList
values={localConstraint.values}
removeValue={removeValue}
setValues={setValuesWithRecord}
setValues={setValues}
getExternalFocusTarget={() =>
addValuesButtonRef.current ??
deleteButtonRef.current
@ -430,7 +422,7 @@ export const EditableConstraint: FC<Props> = ({
)}
constraintValues={constraintValues}
values={localConstraint.values || []}
setValuesWithRecord={setValuesWithRecord}
setValuesWithRecord={setValues}
setValues={setValues}
/>
</LegalValuesContainer>

View File

@ -118,6 +118,7 @@ export const EditableConstraintWrapper = ({
(index: number) => {
const valueCopy = [...localConstraint.values!];
valueCopy.splice(index, 1);
setValues(valueCopy);
},
[localConstraint],
);
@ -131,15 +132,12 @@ export const EditableConstraintWrapper = ({
toggleInvertedOperator={setInvertedOperator}
toggleCaseSensitivity={setCaseInsensitive}
onDelete={onDelete}
constraintChanges={constraintChanges}
setValues={setValues}
setValuesWithRecord={setValuesWithRecord}
setValue={setValue}
constraintValues={constraint?.values || []}
constraintValue={constraint?.value || ''}
contextDefinition={contextDefinition}
removeValue={removeValue}
constraint={constraint}
/>
);
};