Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-07-31 13:47:02 +02:00
Code Issues Projects Releases Wiki Activity

chore: remove registerFrontendClient flag ws-swe1 [discard]

Browse Source
This commit is contained in:
Nuno Góis 2025-06-18 14:19:03 +01:00
parent 810890fe67
commit 9ee511fca1
No known key found for this signature in database
GPG Key ID: 71ECC689F1091765
6 changed files with 12 additions and 97 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

60
frontend/src/component/application/ApplicationChart.tsx
View File

@ -16,7 +16,6 @@ import WarningAmberRounded from '@mui/icons-material/WarningAmberRounded';
import { TimeAgo } from 'component/common/TimeAgo/TimeAgo';
import { usePlausibleTracker } from 'hooks/usePlausibleTracker';
import { getApplicationIssues } from './ApplicationIssues/ApplicationIssues.tsx';
import { useUiFlag } from 'hooks/useUiFlag';
const StyledTable = styled('table')(({ theme }) => ({
fontSize: theme.fontSizes.smallerBody,
@ -197,7 +196,6 @@ export const ApplicationChart = ({ data }: IApplicationChartProps) => {
const { elementRef, width } = useElementWidth();
const navigate = useNavigate();
const theme = useTheme();
const registerFrontendClientEnabled = useUiFlag('registerFrontendClient');
const mode = getApplicationIssues(data);
@ -296,56 +294,14 @@ export const ApplicationChart = ({ data }: IApplicationChartProps) => {
{environment.instanceCount}
</StyledCell>
</tr>
{!registerFrontendClientEnabled ? (
<tr>
<StyledCell>SDK:</StyledCell>
<StyledCell>
{environment.sdks.map(
(sdk) => (
<div key={sdk}>
{sdk}
</div>
),
)}
</StyledCell>
</tr>
) : null}
{registerFrontendClientEnabled &&
environment.backendSdks.length > 0 ? (
<tr>
<StyledCell>
Backend SDK:
</StyledCell>
<StyledCell>
{environment.backendSdks.map(
(sdk) => (
<div key={sdk}>
{sdk}
</div>
),
)}
</StyledCell>
</tr>
) : null}
{registerFrontendClientEnabled &&
environment.frontendSdks.length > 0 ? (
<tr>
<StyledCell>
Frontend SDK:
</StyledCell>
<StyledCell>
{environment.frontendSdks.map(
(sdk) => (
<div key={sdk}>
{sdk}
</div>
),
)}
</StyledCell>
</tr>
) : null}
<tr>
<StyledCell>SDK:</StyledCell>
<StyledCell>
{environment.sdks.map((sdk) => (
<div key={sdk}>{sdk}</div>
))}
</StyledCell>
</tr>
<tr>
<StyledCell>Last seen:</StyledCell>

16
src/lib/features/frontend-api/frontend-api-service.ts
View File

@ -135,21 +135,7 @@ export class FrontendApiService {
ip,
);
if (
metrics.instanceId &&
typeof sdkVersion === 'string' &&
this.flagResolver.isEnabled('registerFrontendClient')
) {
const client = {
appName: metrics.appName,
instanceId: metrics.instanceId,
sdkVersion: sdkVersion,
sdkType: 'frontend' as const,
environment: environment,
projects: this.resolveProject(token),
};
this.services.clientInstanceService.registerFrontendClient(client);
}
// Frontend client registration has been removed as part of the registerFrontendClient flag removal
}
private async clientForFrontendApiToken(token: IApiUser): Promise<Unleash> {

8
src/lib/features/metrics/instance/metrics.test.ts
View File

@ -45,13 +45,7 @@ let services: IUnleashServices;
let destroy: () => Promise<void>;
beforeAll(async () => {
const setup = await getSetup({
experimental: {
flags: {
registerFrontendClient: true,
},
},
});
const setup = await getSetup();
request = setup.request;
stores = setup.stores;
destroy = setup.destroy;

19
src/lib/features/metrics/instance/metrics.ts
View File

@ -223,24 +223,9 @@ export default class ClientMetricsController extends Controller {
const promises: Promise<void>[] = [];
for (const app of applications) {
if (
app.sdkType === 'frontend' &&
typeof app.sdkVersion === 'string'
app.sdkType !== 'frontend' ||
typeof app.sdkVersion !== 'string'
) {
if (
this.flagResolver.isEnabled(
'registerFrontendClient',
)
) {
this.clientInstanceService.registerFrontendClient({
appName: app.appName,
instanceId: app.instanceId,
environment: app.environment,
sdkType: app.sdkType,
sdkVersion: app.sdkVersion,
projects: app.projects,
});
}
} else {
promises.push(
this.clientInstanceService.registerBackendClient(
app,

5
src/lib/types/experimental.ts
View File

@ -55,7 +55,6 @@ export type IFlagKey =
| 'uniqueSdkTracking'
| 'consumptionModel'
| 'edgeObservability'
| 'registerFrontendClient'
| 'reportUnknownFlags'
| 'lastSeenBulkQuery'
| 'lifecycleMetrics'
@ -264,10 +263,6 @@ const flags: IFlags = {
process.env.EXPERIMENTAL_EDGE_OBSERVABILITY,
false,
),
registerFrontendClient: parseEnvVarBoolean(
process.env.UNLEASH_EXPERIMENTAL_REGISTER_FRONTEND_CLIENT,
false,
),
reportUnknownFlags: parseEnvVarBoolean(
process.env.UNLEASH_EXPERIMENTAL_REPORT_UNKNOWN_FLAGS,
false,

1
src/server-dev.ts
View File

@ -51,7 +51,6 @@ process.nextTick(async () => {
deltaApi: true,
uniqueSdkTracking: true,
strictSchemaValidation: true,
registerFrontendClient: true,
reportUnknownFlags: true,
customMetrics: true,
lifecycleMetrics: true,