Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-10-27 11:02:16 +01:00
Code Issues Projects Releases Wiki Activity

fix: sync enabled and variant status (#4345)

Browse Source
This commit is contained in:
Mateusz Kwasniewski 2023-07-26 12:23:39 +02:00 committed by GitHub
parent 909831db6f
commit 9f35c2187f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 36 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
src/lib/features/playground/feature-evaluator/client.ts
View File

@ -199,7 +199,7 @@ export default class UnleashClient {
context: Context,
fallbackVariant?: Variant,
): Variant {
return this.resolveVariant(name, context, true, fallbackVariant);
return this.resolveVariant(name, context, fallbackVariant);
}
// This function is intended to close an issue in the proxy where feature enabled
@ -208,16 +208,28 @@ export default class UnleashClient {
forceGetVariant(
name: string,
context: Context,
forcedResult: Pick<
FeatureStrategiesEvaluationResult,
'result' | 'variant'
>,
fallbackVariant?: Variant,
): Variant {
return this.resolveVariant(name, context, false, fallbackVariant);
return this.resolveVariant(
name,
context,
fallbackVariant,
forcedResult,
);
}
private resolveVariant(
name: string,
context: Context,
checkToggle: boolean,
fallbackVariant?: Variant,
forcedResult?: Pick<
FeatureStrategiesEvaluationResult,
'result' | 'variant'
>,
): Variant {
const fallback = fallbackVariant || getDefaultVariant();
const feature = this.repository.getToggle(name);
@ -227,8 +239,9 @@ export default class UnleashClient {
}
let enabled = true;
if (checkToggle) {
const result = this.isFeatureEnabled(feature, context, () =>
const result =
forcedResult ??
this.isFeatureEnabled(feature, context, () =>
fallbackVariant ? fallbackVariant.enabled : false,
);
enabled = result.result === true;
@ -239,7 +252,6 @@ export default class UnleashClient {
if (!enabled) {
return fallback;
}
}
if (
!feature.variants ||
@ -261,7 +273,7 @@ export default class UnleashClient {
return {
name: variant.name,
payload: variant.payload,
enabled: !checkToggle || enabled,
enabled,
};
}
}

5
src/lib/features/playground/feature-evaluator/feature-evaluator.ts
View File

@ -104,6 +104,10 @@ export class FeatureEvaluator {
forceGetVariant(
name: string,
forcedResults: Pick<
FeatureStrategiesEvaluationResult,
'result' | 'variant'
>,
context: Context = {},
fallbackVariant?: Variant,
): Variant {
@ -111,6 +115,7 @@ export class FeatureEvaluator {
return this.client.forceGetVariant(
name,
enhancedContext,
forcedResults,
fallbackVariant,
);
}

6
src/lib/features/playground/playground-service.ts
View File

@ -176,7 +176,11 @@ export class PlaygroundService {
data: strategyEvaluationResult.strategies,
},
projectId: featureProject[feature.name],
variant: client.getVariant(feature.name, clientContext),
variant: client.forceGetVariant(
feature.name,
strategyEvaluationResult,
clientContext,
),
name: feature.name,
environment,
context,