Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-01-20 00:08:02 +01:00
Code Issues Projects Releases Wiki Activity

chore: validate all tables have primary keys (#6005)

Browse Source 
## About the changes
This is a helpful reminder to have primary keys in all our tables.

Related to [#4303](https://github.com/Unleash/unleash/issues/4303)
This commit is contained in:
Gastón Fournier 2024-01-23 16:38:16 +01:00 committed by GitHub
parent 82ac5a47ad
commit 9f550331ce
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 33 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
src/test/e2e/migrator.e2e.test.ts
View File

@ -7,6 +7,8 @@ import { IDBOption } from '../../lib/types';
log.setLogLevel('error');
const schema = 'up_n_down_migrations_test';
async function initSchema(db: IDBOption): Promise<void> {
const client = new Client(db);
await client.connect();
@ -15,13 +17,42 @@ async function initSchema(db: IDBOption): Promise<void> {
await client.end();
}
async function validateTablesHavePrimaryKeys(db: IDBOption) {
const client = new Client(db);
await client.connect();
const tables = await client.query<{ table_name: string }>(
`SELECT
t.table_name
FROM
information_schema.tables t
LEFT JOIN
information_schema.table_constraints tc ON t.table_schema = tc.table_schema
AND t.table_name = tc.table_name
AND tc.constraint_type = 'PRIMARY KEY'
WHERE
t.table_type = 'BASE TABLE'
AND t.table_schema = '${schema}'
AND t.table_schema NOT IN ('pg_catalog', 'information_schema')
AND tc.constraint_name IS NULL;
`,
);
await client.end();
if ((tables.rowCount ?? 0) > 0) {
throw new Error(
`The following tables do not have a primary key defined: ${tables.rows
.map((r) => r.table_name)
.join(', ')}`,
);
}
}
test('Up & down migrations work', async () => {
jest.setTimeout(15000);
const config = createTestConfig({
db: {
...getDbConfig(),
pool: { min: 1, max: 4 },
schema: 'up_n_down_migrations_test',
schema: schema,
ssl: false,
},
});
@ -42,5 +73,6 @@ test('Up & down migrations work', async () => {
});
await dbm.up();
await validateTablesHavePrimaryKeys(config.db);
await dbm.reset();
});