From a0445d8d148e6f1243ab8c5365b8f8fb73ea4a18 Mon Sep 17 00:00:00 2001
From: unleash-bot <194219037+unleash-bot[bot]@users.noreply.github.com>
Date: Wed, 2 Jul 2025 17:21:36 +0000
Subject: [PATCH] refactor: Permanently enable frontend client registration
---
.../application/ApplicationChart.tsx | 22 ++-----------------
frontend/src/interfaces/uiConfig.ts | 1 -
.../frontend-api/frontend-api-service.ts | 6 +----
.../features/metrics/instance/metrics.test.ts | 4 +---
src/lib/features/metrics/instance/metrics.ts | 22 +++++++------------
src/lib/types/experimental.ts | 5 -----
src/server-dev.ts | 1 -
.../e2e/api/admin/applications.e2e.test.ts | 1 -
8 files changed, 12 insertions(+), 50 deletions(-)
diff --git a/frontend/src/component/application/ApplicationChart.tsx b/frontend/src/component/application/ApplicationChart.tsx
index 3e2ee9323c..526c43bc6b 100644
--- a/frontend/src/component/application/ApplicationChart.tsx
+++ b/frontend/src/component/application/ApplicationChart.tsx
@@ -197,7 +197,6 @@ export const ApplicationChart = ({ data }: IApplicationChartProps) => {
const { elementRef, width } = useElementWidth();
const navigate = useNavigate();
const theme = useTheme();
- const registerFrontendClientEnabled = useUiFlag('registerFrontendClient');
const mode = getApplicationIssues(data);
@@ -296,23 +295,7 @@ export const ApplicationChart = ({ data }: IApplicationChartProps) => {
{environment.instanceCount}
- {!registerFrontendClientEnabled ? (
-
- SDK:
-
- {environment.sdks.map(
- (sdk) => (
-
- {sdk}
-
- ),
- )}
-
-
- ) : null}
-
- {registerFrontendClientEnabled &&
- environment.backendSdks.length > 0 ? (
+ {environment.backendSdks.length > 0 ? (
Backend SDK:
@@ -329,8 +312,7 @@ export const ApplicationChart = ({ data }: IApplicationChartProps) => {
) : null}
- {registerFrontendClientEnabled &&
- environment.frontendSdks.length > 0 ? (
+ {environment.frontendSdks.length > 0 ? (
Frontend SDK:
diff --git a/frontend/src/interfaces/uiConfig.ts b/frontend/src/interfaces/uiConfig.ts
index 5bcda3c8c5..7e641a1506 100644
--- a/frontend/src/interfaces/uiConfig.ts
+++ b/frontend/src/interfaces/uiConfig.ts
@@ -84,7 +84,6 @@ export type UiFlags = {
showUserDeviceCount?: boolean;
consumptionModel?: boolean;
edgeObservability?: boolean;
- registerFrontendClient?: boolean;
customMetrics?: boolean;
lifecycleMetrics?: boolean;
createFlagDialogCache?: boolean;
diff --git a/src/lib/features/frontend-api/frontend-api-service.ts b/src/lib/features/frontend-api/frontend-api-service.ts
index cc17714ff6..2bb51f1d93 100644
--- a/src/lib/features/frontend-api/frontend-api-service.ts
+++ b/src/lib/features/frontend-api/frontend-api-service.ts
@@ -135,11 +135,7 @@ export class FrontendApiService {
ip,
);
- if (
- metrics.instanceId &&
- typeof sdkVersion === 'string' &&
- this.flagResolver.isEnabled('registerFrontendClient')
- ) {
+ if (metrics.instanceId && typeof sdkVersion === 'string') {
const client = {
appName: metrics.appName,
instanceId: metrics.instanceId,
diff --git a/src/lib/features/metrics/instance/metrics.test.ts b/src/lib/features/metrics/instance/metrics.test.ts
index 0f729d9cb8..3bab2d127f 100644
--- a/src/lib/features/metrics/instance/metrics.test.ts
+++ b/src/lib/features/metrics/instance/metrics.test.ts
@@ -47,9 +47,7 @@ let destroy: () => Promise;
beforeAll(async () => {
const setup = await getSetup({
experimental: {
- flags: {
- registerFrontendClient: true,
- },
+ flags: {},
},
});
request = setup.request;
diff --git a/src/lib/features/metrics/instance/metrics.ts b/src/lib/features/metrics/instance/metrics.ts
index 2cc73d502a..66a057f41b 100644
--- a/src/lib/features/metrics/instance/metrics.ts
+++ b/src/lib/features/metrics/instance/metrics.ts
@@ -238,20 +238,14 @@ export default class ClientMetricsController extends Controller {
app.sdkType === 'frontend' &&
typeof app.sdkVersion === 'string'
) {
- if (
- this.flagResolver.isEnabled(
- 'registerFrontendClient',
- )
- ) {
- this.clientInstanceService.registerFrontendClient({
- appName: app.appName,
- instanceId: app.instanceId,
- environment: app.environment,
- sdkType: app.sdkType,
- sdkVersion: app.sdkVersion,
- projects: app.projects,
- });
- }
+ this.clientInstanceService.registerFrontendClient({
+ appName: app.appName,
+ instanceId: app.instanceId,
+ environment: app.environment,
+ sdkType: app.sdkType,
+ sdkVersion: app.sdkVersion,
+ projects: app.projects,
+ });
} else {
promises.push(
this.clientInstanceService.registerBackendClient(
diff --git a/src/lib/types/experimental.ts b/src/lib/types/experimental.ts
index 373c2bc8d9..0394f465e3 100644
--- a/src/lib/types/experimental.ts
+++ b/src/lib/types/experimental.ts
@@ -54,7 +54,6 @@ export type IFlagKey =
| 'uniqueSdkTracking'
| 'consumptionModel'
| 'edgeObservability'
- | 'registerFrontendClient'
| 'reportUnknownFlags'
| 'lifecycleMetrics'
| 'customMetrics'
@@ -260,10 +259,6 @@ const flags: IFlags = {
process.env.EXPERIMENTAL_EDGE_OBSERVABILITY,
false,
),
- registerFrontendClient: parseEnvVarBoolean(
- process.env.UNLEASH_EXPERIMENTAL_REGISTER_FRONTEND_CLIENT,
- false,
- ),
reportUnknownFlags: parseEnvVarBoolean(
process.env.UNLEASH_EXPERIMENTAL_REPORT_UNKNOWN_FLAGS,
false,
diff --git a/src/server-dev.ts b/src/server-dev.ts
index 06ddfe230f..d03ccb88d3 100644
--- a/src/server-dev.ts
+++ b/src/server-dev.ts
@@ -51,7 +51,6 @@ process.nextTick(async () => {
deltaApi: true,
uniqueSdkTracking: true,
strictSchemaValidation: true,
- registerFrontendClient: true,
reportUnknownFlags: true,
customMetrics: true,
lifecycleMetrics: true,
diff --git a/src/test/e2e/api/admin/applications.e2e.test.ts b/src/test/e2e/api/admin/applications.e2e.test.ts
index 78e34a38da..12a70452a2 100644
--- a/src/test/e2e/api/admin/applications.e2e.test.ts
+++ b/src/test/e2e/api/admin/applications.e2e.test.ts
@@ -55,7 +55,6 @@ beforeAll(async () => {
experimental: {
flags: {
strictSchemaValidation: true,
- registerFrontendClient: true,
},
},
},