Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-06-18 01:18:23 +02:00
Code Issues Projects Releases Wiki Activity

fix: access overview fallback to email (#9582)

Browse Source 
https://linear.app/unleash/issue/2-3430/fix-undefined-in-access-overview-when-user-name-is-unavailable

Adds a fallback to email in case the name is not available.

Also switches the priority of the fallbacks to be consistent with other
places in our codebase (email > username) and uses `||` instead of `??`
because falsy values don't provide much informational value anyways.


![image](https://github.com/user-attachments/assets/2726247c-b7ba-4ed8-8589-f56fff63d031)
This commit is contained in:
Nuno Góis 2025-03-20 11:02:19 +00:00 committed by GitHub
parent afd24aa58a
commit a10dca44f6
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
frontend/src/component/admin/users/AccessOverview/AccessOverview.tsx
View File

@ -153,7 +153,7 @@ export const AccessOverview = () => {
isLoading={loading} isLoading={loading}
header={ header={
<PageHeader <PageHeader
title={`Access overview for ${user.name ?? user.username}`} title={`Access overview for ${user.name || user.email || user.username}`}
actions={ actions={
<ConditionallyRender <ConditionallyRender
condition={!isSmallScreen} condition={!isSmallScreen}

2
frontend/src/component/user/Profile/ProfileTab/ProfileTab.tsx
View File

@ -131,7 +131,7 @@ export const ProfileTab = ({ user }: IProfileTabProps) => {
<StyledAvatar user={user} /> <StyledAvatar user={user} />
<StyledInfo> <StyledInfo>
<StyledInfoName> <StyledInfoName>
{user.name || user.username} {user.name || user.email || user.username}
</StyledInfoName> </StyledInfoName>
<Typography variant='body1'>{user.email}</Typography> <Typography variant='body1'>{user.email}</Typography>
</StyledInfo> </StyledInfo>