1
0
mirror of https://github.com/Unleash/unleash.git synced 2025-11-10 01:19:53 +01:00

chore: Update "by" to "created by" in the global change request list (#10934)

<img width="132" height="132" alt="image"
src="https://github.com/user-attachments/assets/544bc469-0c3c-4a05-b524-6d9fbfe87215"
/>

Additionally, remove the redundant `id` properties from the column
accessors. They don't seem to have any effect and I didn't see them in
other code.
This commit is contained in:
Thomas Heartman 2025-11-06 14:33:25 +01:00 committed by GitHub
parent 4e2b39fcf8
commit a116405779
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -82,13 +82,11 @@ const ChangeRequestsInner = ({ user }: { user: IUser }) => {
const columns = useMemo( const columns = useMemo(
() => [ () => [
columnHelper.accessor('id', { columnHelper.accessor('id', {
id: 'Title',
header: 'Title', header: 'Title',
meta: { width: '35%' }, meta: { width: '35%' },
cell: GlobalChangeRequestTitleCell, cell: GlobalChangeRequestTitleCell,
}), }),
columnHelper.accessor('features', { columnHelper.accessor('features', {
id: 'Updated feature flags',
header: 'Updated feature flags', header: 'Updated feature flags',
enableSorting: false, enableSorting: false,
cell: ({ cell: ({
@ -111,20 +109,17 @@ const ChangeRequestsInner = ({ user }: { user: IUser }) => {
}, },
}), }),
columnHelper.accessor('createdBy', { columnHelper.accessor('createdBy', {
id: 'By', header: 'Created by',
header: 'By',
meta: { width: '10%' }, meta: { width: '10%' },
enableSorting: false, enableSorting: false,
cell: ({ getValue }) => <AvatarCell value={getValue()} />, cell: ({ getValue }) => <AvatarCell value={getValue()} />,
}), }),
columnHelper.accessor('createdAt', { columnHelper.accessor('createdAt', {
id: 'Submitted',
header: 'Submitted', header: 'Submitted',
meta: { width: '5%' }, meta: { width: '5%' },
cell: ({ getValue }) => <TimeAgoCell value={getValue()} />, cell: ({ getValue }) => <TimeAgoCell value={getValue()} />,
}), }),
columnHelper.accessor('environment', { columnHelper.accessor('environment', {
id: 'Environment',
header: 'Environment', header: 'Environment',
meta: { width: '10%' }, meta: { width: '10%' },
cell: ({ getValue }) => ( cell: ({ getValue }) => (
@ -132,7 +127,6 @@ const ChangeRequestsInner = ({ user }: { user: IUser }) => {
), ),
}), }),
columnHelper.accessor('state', { columnHelper.accessor('state', {
id: 'Status',
header: 'Status', header: 'Status',
meta: { width: '10%' }, meta: { width: '10%' },
cell: ({ getValue, row }) => ( cell: ({ getValue, row }) => (