From a16520ddda9daf84030c3d9b7b2399b0674273e0 Mon Sep 17 00:00:00 2001
From: olav <mail@olav.io>
Date: Wed, 23 Mar 2022 09:12:10 +0100
Subject: [PATCH] refactor: fix Tooltip ref warning (#804)

* refactor: fix Tooltip ref warning

* refactor: add missing button labels
---
 .../StrategiesList/StrategiesList.tsx          | 18 ++++++++++--------
 .../__snapshots__/list-component-test.jsx.snap | 10 ++++++++--
 2 files changed, 18 insertions(+), 10 deletions(-)

diff --git a/frontend/src/component/strategies/StrategiesList/StrategiesList.tsx b/frontend/src/component/strategies/StrategiesList/StrategiesList.tsx
index 9d7bbe51b8..21e8920f8c 100644
--- a/frontend/src/component/strategies/StrategiesList/StrategiesList.tsx
+++ b/frontend/src/component/strategies/StrategiesList/StrategiesList.tsx
@@ -163,12 +163,14 @@ export const StrategiesList = () => {
 
     const reactivateButton = (strategy: ICustomStrategy) => (
         <Tooltip title="Reactivate activation strategy">
-            <PermissionIconButton
-                onClick={() => onReactivateStrategy(strategy)}
-                permission={UPDATE_STRATEGY}
-            >
-                <VisibilityOff />
-            </PermissionIconButton>
+            <div>
+                <PermissionIconButton
+                    onClick={() => onReactivateStrategy(strategy)}
+                    permission={UPDATE_STRATEGY}
+                >
+                    <VisibilityOff titleAccess="Reactivate" />
+                </PermissionIconButton>
+            </div>
         </Tooltip>
     );
 
@@ -179,7 +181,7 @@ export const StrategiesList = () => {
                 <Tooltip title="You cannot deprecate the default strategy">
                     <div>
                         <IconButton disabled>
-                            <Visibility />
+                            <Visibility titleAccess="Deprecate strategy" />
                         </IconButton>
                     </div>
                 </Tooltip>
@@ -190,7 +192,7 @@ export const StrategiesList = () => {
                         onClick={() => onDeprecateStrategy(strategy)}
                         permission={UPDATE_STRATEGY}
                     >
-                        <Visibility />
+                        <Visibility titleAccess="Deprecate strategy" />
                     </PermissionIconButton>
                 </div>
             }
diff --git a/frontend/src/component/strategies/__tests__/__snapshots__/list-component-test.jsx.snap b/frontend/src/component/strategies/__tests__/__snapshots__/list-component-test.jsx.snap
index d1f70d522a..3936770715 100644
--- a/frontend/src/component/strategies/__tests__/__snapshots__/list-component-test.jsx.snap
+++ b/frontend/src/component/strategies/__tests__/__snapshots__/list-component-test.jsx.snap
@@ -159,14 +159,17 @@ exports[`renders correctly with one strategy 1`] = `
                 className="MuiIconButton-label"
               >
                 <svg
-                  aria-hidden={true}
                   className="MuiSvgIcon-root"
                   focusable="false"
+                  role="img"
                   viewBox="0 0 24 24"
                 >
                   <path
                     d="M12 4.5C7 4.5 2.73 7.61 1 12c1.73 4.39 6 7.5 11 7.5s9.27-3.11 11-7.5c-1.73-4.39-6-7.5-11-7.5zM12 17c-2.76 0-5-2.24-5-5s2.24-5 5-5 5 2.24 5 5-2.24 5-5 5zm0-8c-1.66 0-3 1.34-3 3s1.34 3 3 3 3-1.34 3-3-1.34-3-3-3z"
                   />
+                  <title>
+                    Deprecate strategy
+                  </title>
                 </svg>
               </span>
               <span
@@ -431,14 +434,17 @@ exports[`renders correctly with one strategy without permissions 1`] = `
                 className="MuiIconButton-label"
               >
                 <svg
-                  aria-hidden={true}
                   className="MuiSvgIcon-root"
                   focusable="false"
+                  role="img"
                   viewBox="0 0 24 24"
                 >
                   <path
                     d="M12 4.5C7 4.5 2.73 7.61 1 12c1.73 4.39 6 7.5 11 7.5s9.27-3.11 11-7.5c-1.73-4.39-6-7.5-11-7.5zM12 17c-2.76 0-5-2.24-5-5s2.24-5 5-5 5 2.24 5 5-2.24 5-5 5zm0-8c-1.66 0-3 1.34-3 3s1.34 3 3 3 3-1.34 3-3-1.34-3-3-3z"
                   />
+                  <title>
+                    Deprecate strategy
+                  </title>
                 </svg>
               </span>
               <span