Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-06-23 01:16:27 +02:00
Code Issues Projects Releases Wiki Activity

refactor: remove public signup link feature flag (#2423)

Browse Source 
## About the changes
Cleanup: remove feature flag.

Closes
[1-356/remove-feature-flag-from-the-code](https://linear.app/unleash/issue/1-356/remove-feature-flag-from-the-code)
This commit is contained in:
Tymoteusz Czech 2022-11-15 10:03:20 +01:00 committed by GitHub
parent 8b057a1466
commit a191313956
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 1 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
frontend/src/component/admin/users/UsersAdmin.tsx
View File

@ -6,19 +6,14 @@ import { ConditionallyRender } from 'component/common/ConditionallyRender/Condit
import { ADMIN } from 'component/providers/AccessProvider/permissions'; import { ADMIN } from 'component/providers/AccessProvider/permissions';
import { AdminAlert } from 'component/common/AdminAlert/AdminAlert'; import { AdminAlert } from 'component/common/AdminAlert/AdminAlert';
import { InviteLinkBar } from './InviteLinkBar/InviteLinkBar'; import { InviteLinkBar } from './InviteLinkBar/InviteLinkBar';
import useUiConfig from 'hooks/api/getters/useUiConfig/useUiConfig';
const UsersAdmin = () => { const UsersAdmin = () => {
const { hasAccess } = useContext(AccessContext); const { hasAccess } = useContext(AccessContext);
const { uiConfig } = useUiConfig();
return ( return (
<div> <div>
<AdminMenu /> <AdminMenu />
<ConditionallyRender <InviteLinkBar />
condition={Boolean(uiConfig?.flags?.publicSignup)}
show={<InviteLinkBar />}
/>
<ConditionallyRender <ConditionallyRender
condition={hasAccess(ADMIN)} condition={hasAccess(ADMIN)}
show={<UsersList />} show={<UsersList />}

1
frontend/src/interfaces/uiConfig.ts
View File

@ -40,7 +40,6 @@ export interface IFlags {
UG?: boolean; UG?: boolean;
ENABLE_DARK_MODE_SUPPORT?: boolean; ENABLE_DARK_MODE_SUPPORT?: boolean;
embedProxyFrontend?: boolean; embedProxyFrontend?: boolean;
publicSignup?: boolean;
syncSSOGroups?: boolean; syncSSOGroups?: boolean;
changeRequests?: boolean; changeRequests?: boolean;
cloneEnvironment?: boolean; cloneEnvironment?: boolean;

2
src/lib/__snapshots__/create-config.test.ts.snap
View File

@ -73,7 +73,6 @@ exports[`should create default config 1`] = `
"cloneEnvironment": false, "cloneEnvironment": false,
"embedProxy": false, "embedProxy": false,
"embedProxyFrontend": false, "embedProxyFrontend": false,
"publicSignup": false,
"responseTimeWithAppName": false, "responseTimeWithAppName": false,
"syncSSOGroups": false, "syncSSOGroups": false,
}, },
@ -87,7 +86,6 @@ exports[`should create default config 1`] = `
"cloneEnvironment": false, "cloneEnvironment": false,
"embedProxy": false, "embedProxy": false,
"embedProxyFrontend": false, "embedProxyFrontend": false,
"publicSignup": false,
"responseTimeWithAppName": false, "responseTimeWithAppName": false,
"syncSSOGroups": false, "syncSSOGroups": false,
}, },

4
src/lib/types/experimental.ts
View File

@ -26,10 +26,6 @@ export const defaultExperimentalOptions = {
process.env.UNLEASH_EXPERIMENTAL_BATCH_METRICS, process.env.UNLEASH_EXPERIMENTAL_BATCH_METRICS,
false, false,
), ),
publicSignup: parseEnvVarBoolean(
process.env.UNLEASH_EXPERIMENTAL_PUBLIC_SIGNUP,
false,
),
responseTimeWithAppName: parseEnvVarBoolean( responseTimeWithAppName: parseEnvVarBoolean(
process.env.UNLEASH_EXPERIMENTAL_RESPONSE_TIME_WITH_APP_NAME, process.env.UNLEASH_EXPERIMENTAL_RESPONSE_TIME_WITH_APP_NAME,
false, false,