From a1e98056ec77e18a77a3b09ac9f65b89d97ce86d Mon Sep 17 00:00:00 2001 From: Thomas Heartman Date: Tue, 5 Sep 2023 13:40:03 +0200 Subject: [PATCH] feature naming patterns: allow empty values in examples and patterns (#4611) Allow empty patterns and examples for feature naming. This fixes an issue where the form would break, not allowing you to create new projects at all. --- src/lib/openapi/spec/create-feature-naming-pattern-schema.ts | 1 - src/lib/services/project-schema.ts | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/lib/openapi/spec/create-feature-naming-pattern-schema.ts b/src/lib/openapi/spec/create-feature-naming-pattern-schema.ts index 827d3647b2..5c5d4403a9 100644 --- a/src/lib/openapi/spec/create-feature-naming-pattern-schema.ts +++ b/src/lib/openapi/spec/create-feature-naming-pattern-schema.ts @@ -12,7 +12,6 @@ export const createFeatureNamingPatternSchema = { description: 'A JavaScript regular expression pattern, without the start and end delimiters. Optional flags are not allowed.', example: '[a-z]{2,5}.team-[a-z]+.[a-z-]+', - pattern: '.*', }, example: { type: 'string', diff --git a/src/lib/services/project-schema.ts b/src/lib/services/project-schema.ts index ee0fb15502..8f694dbbd0 100644 --- a/src/lib/services/project-schema.ts +++ b/src/lib/services/project-schema.ts @@ -11,8 +11,8 @@ export const projectSchema = joi defaultStickiness: joi.string().default('default'), featureLimit: joi.number().allow(null).optional(), featureNaming: joi.object().keys({ - pattern: joi.string().allow(null).optional(), - example: joi.string().allow(null).optional(), + pattern: joi.string().allow(null).allow('').optional(), + example: joi.string().allow(null).allow('').optional(), }), }) .options({ allowUnknown: false, stripUnknown: true });