diff --git a/frontend/src/component/feature/FeatureView/CleanupReminder/CleanupReminder.tsx b/frontend/src/component/feature/FeatureView/CleanupReminder/CleanupReminder.tsx index 5f7cfac9c9..3e690a076c 100644 --- a/frontend/src/component/feature/FeatureView/CleanupReminder/CleanupReminder.tsx +++ b/frontend/src/component/feature/FeatureView/CleanupReminder/CleanupReminder.tsx @@ -34,6 +34,9 @@ const ActionsBox = styled(Box)(({ theme }) => ({ type ReminderType = 'complete' | 'removeCode' | 'archive' | null; +export const COMPLETE_REMINDER_DAYS = 30; +export const REMOVE_CODE_REMINDER_DAYS = 3; + export const CleanupReminder: FC<{ feature: IFeatureToggle; onChange: () => void; @@ -62,7 +65,10 @@ export const CleanupReminder: FC<{ const determineReminder = (): ReminderType => { if (!currentStage || !isRelevantType) return null; - if (currentStage.name === 'live' && daysInStage > 30) { + if ( + currentStage.name === 'live' && + daysInStage > COMPLETE_REMINDER_DAYS + ) { return 'complete'; } if ( @@ -72,7 +78,7 @@ export const CleanupReminder: FC<{ if (isSafeToArchive(currentStage.environments)) { return 'archive'; } - if (daysInStage > 2) { + if (daysInStage > REMOVE_CODE_REMINDER_DAYS) { return 'removeCode'; } } diff --git a/frontend/src/component/feature/FeatureView/FeatureOverview/FeatureLifecycle/isSafeToArchive.ts b/frontend/src/component/feature/FeatureView/FeatureOverview/FeatureLifecycle/isSafeToArchive.ts index 7a04953378..75e402c308 100644 --- a/frontend/src/component/feature/FeatureView/FeatureOverview/FeatureLifecycle/isSafeToArchive.ts +++ b/frontend/src/component/feature/FeatureView/FeatureOverview/FeatureLifecycle/isSafeToArchive.ts @@ -1,13 +1,16 @@ import { isBefore, parseISO, subDays } from 'date-fns'; +// no metrics received in this period +const SAFE_TO_ARCHIVE_DAYS = 2; + export function isSafeToArchive( environments: Array<{ name: string; lastSeenAt: string }>, ) { - const twoDaysAgo = subDays(new Date(), 2); + const daysAgo = subDays(new Date(), SAFE_TO_ARCHIVE_DAYS); return environments.every((env) => { const lastSeenDate = parseISO(env.lastSeenAt); - return isBefore(lastSeenDate, twoDaysAgo); + return isBefore(lastSeenDate, daysAgo); }); }