chore remove and clean some stuff (#9993)

- Deletes an unused file
- Fixes a console.error due to a prop being passed on to the HTML
component
- Puts all editable constraint files within a separate directory.

frontend/src/component/common/ConstraintsList/StrategyEvaluationChip/StrategyEvaluationChip.tsx

@@ -2,25 +2,25 @@ import { forwardRef } from 'react';
 import type { ChipProps } from '@mui/material';
 import { Chip, styled } from '@mui/material';
 
-const StyledChip = styled(Chip)<{ multiline?: boolean }>(
-    ({ theme, multiline }) => ({
-        borderRadius: `${theme.shape.borderRadius}px`,
-        padding: theme.spacing(0.25, 0),
-        fontSize: theme.fontSizes.smallerBody,
-        height: 'auto',
-        background: theme.palette.secondary.light,
-        border: `1px solid ${theme.palette.secondary.border}`,
-        color: theme.palette.secondary.dark,
-        fontWeight: theme.typography.fontWeightBold,
-        ...(multiline
-            ? {
-                  '.MuiChip-label': {
-                      whiteSpace: 'collapse',
-                  },
-              }
-            : {}),
-    }),
-);
+const StyledChip = styled(Chip, {
+    shouldForwardProp: (prop) => prop !== 'multiline',
+})<{ multiline?: boolean }>(({ theme, multiline }) => ({
+    borderRadius: `${theme.shape.borderRadius}px`,
+    padding: theme.spacing(0.25, 0),
+    fontSize: theme.fontSizes.smallerBody,
+    height: 'auto',
+    background: theme.palette.secondary.light,
+    border: `1px solid ${theme.palette.secondary.border}`,
+    color: theme.palette.secondary.dark,
+    fontWeight: theme.typography.fontWeightBold,
+    ...(multiline
+        ? {
+              '.MuiChip-label': {
+                  whiteSpace: 'collapse',
+              },
+          }
+        : {}),
+}));
 
 export const StrategyEvaluationChip = forwardRef<
     HTMLDivElement,

frontend/src/component/common/NewConstraintAccordion/ConstraintAccordionView/ConstraintAccordionViewBody/MultipleValues/MultipleValues.tsx

@@ -2,7 +2,7 @@ import { useState } from 'react';
 import { Chip, styled } from '@mui/material';
 import { ConditionallyRender } from 'component/common/ConditionallyRender/ConditionallyRender';
 import StringTruncator from 'component/common/StringTruncator/StringTruncator';
-import { ConstraintValueSearch as NewConstraintValueSearch } from 'component/feature/FeatureStrategy/FeatureStrategyConstraints/ConstraintValueSearch';
+import { ConstraintValueSearch as NewConstraintValueSearch } from 'component/feature/FeatureStrategy/FeatureStrategyConstraints/EditableConstraint/ConstraintValueSearch';
 import { useUiFlag } from 'hooks/useUiFlag';
 import { ConstraintValueSearch } from 'component/common/NewConstraintAccordion/ConstraintValueSearch/ConstraintValueSearch';
 

frontend/src/component/common/NewConstraintAccordion/ConstraintsList/EditableConstraintsList.tsx

@@ -10,7 +10,7 @@ import {
     createEmptyConstraint,
 } from 'component/common/LegacyConstraintAccordion/ConstraintAccordionList/createEmptyConstraint';
 import { ConstraintsList } from 'component/common/ConstraintsList/ConstraintsList';
-import { EditableConstraint } from 'component/feature/FeatureStrategy/FeatureStrategyConstraints/EditableConstraint';
+import { EditableConstraint } from 'component/feature/FeatureStrategy/FeatureStrategyConstraints/EditableConstraint/EditableConstraint';
 export interface IEditableConstraintsListRef {
     addConstraint?: (contextName: string) => void;
 }

frontend/src/component/common/NewConstraintAccordion/NewConstraintAccordionList/NewConstraintAccordionList.tsx

@@ -10,7 +10,7 @@ import { NewConstraintAccordion } from 'component/common/NewConstraintAccordion/
 import { ConstraintsList } from 'component/common/ConstraintsList/ConstraintsList';
 import { useUiFlag } from 'hooks/useUiFlag';
 import { ConstraintAccordionView } from 'component/common/NewConstraintAccordion/ConstraintAccordionView/ConstraintAccordionView';
-import { EditableConstraint } from 'component/feature/FeatureStrategy/FeatureStrategyConstraints/EditableConstraint';
+import { EditableConstraint } from 'component/feature/FeatureStrategy/FeatureStrategyConstraints/EditableConstraint/EditableConstraint';
 
 export interface IConstraintAccordionListProps {
     constraints: IConstraint[];

frontend/src/component/feature/FeatureStrategy/FeatureStrategyConstraints/resolve-legal-values.ts

@@ -1,27 +0,0 @@
-import type {
-    IUnleashContextDefinition,
-    ILegalValue,
-} from 'interfaces/context';
-import type { IConstraint } from 'interfaces/strategy';
-
-export const resolveLegalValues = (
-    values: IConstraint['values'] = [],
-    legalValues: IUnleashContextDefinition['legalValues'] = [],
-): { legalValues: ILegalValue[]; deletedLegalValues: ILegalValue[] } => {
-    if (legalValues.length === 0) {
-        return {
-            legalValues: [],
-            deletedLegalValues: [],
-        };
-    }
-
-    const existingLegalValues = new Set(legalValues.map(({ value }) => value));
-    const deletedLegalValues = values
-        .filter((value) => !existingLegalValues.has(value))
-        .map((v) => ({ value: v, description: '' }));
-
-    return {
-        legalValues,
-        deletedLegalValues,
-    };
-};