Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-07-12 13:48:35 +02:00
Code Issues Projects Releases Wiki Activity

fix: now null sdks will also be handled nicely (#8984)

Browse Source 
We had some error logs, that when SDK is null, then the application
overview query was failing.

This solves it
This commit is contained in:
Jaanus Sellin 2024-12-16 12:11:48 +02:00 committed by GitHub
parent 39ca516823
commit a2f82716d1
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/lib/db/client-applications-store.ts
View File

@ -325,7 +325,7 @@ export default class ClientApplicationsStore
'COUNT(DISTINCT ci.instance_id) as unique_instance_count', 'COUNT(DISTINCT ci.instance_id) as unique_instance_count',
), ),
this.db.raw( this.db.raw(
'ARRAY_AGG(DISTINCT ci.sdk_version) as sdk_versions', 'ARRAY_AGG(DISTINCT ci.sdk_version) FILTER (WHERE ci.sdk_version IS NOT NULL) as sdk_versions',
), ),
this.db.raw('MAX(ci.last_seen) as latest_last_seen'), this.db.raw('MAX(ci.last_seen) as latest_last_seen'),
]) ])
@ -394,7 +394,7 @@ export default class ClientApplicationsStore
env = { env = {
name: environment, name: environment,
instanceCount: Number(unique_instance_count), instanceCount: Number(unique_instance_count),
sdks: sdk_versions, sdks: sdk_versions || [],
lastSeen: latest_last_seen, lastSeen: latest_last_seen,
issues: { issues: {
missingFeatures: featuresNotMappedToProject missingFeatures: featuresNotMappedToProject
@ -412,7 +412,7 @@ export default class ClientApplicationsStore
return acc; return acc;
}, []); }, []);
environments.forEach((env) => { environments.forEach((env) => {
env.sdks?.sort(); env.sdks.sort();
}); });
return { return {

1
src/lib/openapi/spec/application-environment-instances-schema.ts
View File

@ -24,6 +24,7 @@ export const applicationEnvironmentInstancesSchema = {
}, },
sdkVersion: { sdkVersion: {
type: 'string', type: 'string',
nullable: true,
description: description:
'An SDK version identifier. Usually formatted as "unleash-client-<language>:<version>"', 'An SDK version identifier. Usually formatted as "unleash-client-<language>:<version>"',
example: 'unleash-client-java:7.0.0', example: 'unleash-client-java:7.0.0',