From a4ec4a0dbb49ab8a7031b4a5d77207296316bcb2 Mon Sep 17 00:00:00 2001 From: Thomas Heartman Date: Wed, 22 Nov 2023 13:19:25 +0100 Subject: [PATCH] feat: update impl up to API level. --- src/lib/features/segment/segment-controller.ts | 2 +- src/test/e2e/api/admin/segment.e2e.test.ts | 10 +++++++--- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/src/lib/features/segment/segment-controller.ts b/src/lib/features/segment/segment-controller.ts index 833b05d353..8a0c8c8d8c 100644 --- a/src/lib/features/segment/segment-controller.ts +++ b/src/lib/features/segment/segment-controller.ts @@ -369,7 +369,7 @@ export class SegmentsController extends Controller { featureName: strategy.featureName, strategyName: strategy.strategyName, environment: strategy.environment, - changeRequestIds: strategy.changeRequestIds, + changeRequests: strategy.changeRequests, }); res.json({ diff --git a/src/test/e2e/api/admin/segment.e2e.test.ts b/src/test/e2e/api/admin/segment.e2e.test.ts index cad9c0670d..30cc6c4168 100644 --- a/src/test/e2e/api/admin/segment.e2e.test.ts +++ b/src/test/e2e/api/admin/segment.e2e.test.ts @@ -429,6 +429,7 @@ test('Should show usage in features and projects', async () => { }); describe('detect strategy usage in change requests', () => { + const CR_TITLE = 'My change request'; const CR_ID = 54321; let user; @@ -445,7 +446,7 @@ describe('detect strategy usage in change requests', () => { created_by: user.id, created_at: '2023-01-01 00:00:00', min_approvals: 1, - title: 'My change request', + title: CR_TITLE, }); }); afterAll(async () => { @@ -529,7 +530,7 @@ describe('detect strategy usage in change requests', () => { featureName: toggle.name, projectId: 'default', strategyName: 'flexibleRollout', - changeRequestIds: [CR_ID], + changeRequests: [{ id: CR_ID, title: CR_TITLE }], }, ]); expect(strategies).toStrictEqual([]); @@ -578,7 +579,10 @@ describe('detect strategy usage in change requests', () => { await fetchSegmentStrategies(segment.id); expect(changeRequestStrategies).toMatchObject([ - { id: strategyId, changeRequestIds: [CR_ID] }, + { + id: strategyId, + changeRequests: [{ id: CR_ID, title: CR_TITLE }], + }, ]); expect(strategies).toStrictEqual([]); });