From a507ca91a5aadc1e7b4874e2ac2ae6903c1a3181 Mon Sep 17 00:00:00 2001 From: Simon Hornby Date: Wed, 7 Aug 2024 09:19:42 +0200 Subject: [PATCH] chore: remove scim api flag (#7780) --- src/lib/__snapshots__/create-config.test.ts.snap | 1 - src/lib/routes/admin-api/user-admin.ts | 1 - src/lib/types/experimental.ts | 5 ----- src/test/e2e/api/admin/user-admin.scim.e2e.test.ts | 1 - 4 files changed, 8 deletions(-) diff --git a/src/lib/__snapshots__/create-config.test.ts.snap b/src/lib/__snapshots__/create-config.test.ts.snap index c54c50603c..146f5b0b03 100644 --- a/src/lib/__snapshots__/create-config.test.ts.snap +++ b/src/lib/__snapshots__/create-config.test.ts.snap @@ -155,7 +155,6 @@ exports[`should create default config 1`] = ` "resourceLimits": false, "responseTimeMetricsFix": false, "responseTimeWithAppNameKillSwitch": false, - "scimApi": false, "showInactiveUsers": false, "signals": false, "strictSchemaValidation": false, diff --git a/src/lib/routes/admin-api/user-admin.ts b/src/lib/routes/admin-api/user-admin.ts index 42ca488766..a91f3461dc 100644 --- a/src/lib/routes/admin-api/user-admin.ts +++ b/src/lib/routes/admin-api/user-admin.ts @@ -728,7 +728,6 @@ export default class UserAdminController extends Controller { scimId, }: Pick): Promise { if (!this.isEnterprise) return; - if (!this.flagResolver.isEnabled('scimApi')) return; const isScimUser = await this.isScimUser({ id, scimId }); if (!isScimUser) return; diff --git a/src/lib/types/experimental.ts b/src/lib/types/experimental.ts index ec57d542a9..cf1a152b77 100644 --- a/src/lib/types/experimental.ts +++ b/src/lib/types/experimental.ts @@ -49,7 +49,6 @@ export type IFlagKey = | 'disablePublishUnannouncedEvents' | 'outdatedSdksBanner' | 'responseTimeMetricsFix' - | 'scimApi' | 'displayEdgeBanner' | 'disableShowContextFieldSelectionValues' | 'projectOverviewRefactorFeedback' @@ -252,10 +251,6 @@ const flags: IFlags = { process.env.UNLEASH_EXPERIMENTAL_QUERY_MISSING_TOKENS, false, ), - scimApi: parseEnvVarBoolean( - process.env.UNLEASH_EXPERIMENTAL_SCIM_API, - false, - ), displayEdgeBanner: parseEnvVarBoolean( process.env.UNLEASH_EXPERIMENTAL_DISPLAY_EDGE_BANNER, false, diff --git a/src/test/e2e/api/admin/user-admin.scim.e2e.test.ts b/src/test/e2e/api/admin/user-admin.scim.e2e.test.ts index 3461ab1f66..4a78191c2d 100644 --- a/src/test/e2e/api/admin/user-admin.scim.e2e.test.ts +++ b/src/test/e2e/api/admin/user-admin.scim.e2e.test.ts @@ -35,7 +35,6 @@ beforeAll(async () => { experimental: { flags: { strictSchemaValidation: true, - scimApi: true, }, }, });