From a76d1c13ba536b5a6e5422ee83cb3719381c0fcd Mon Sep 17 00:00:00 2001
From: Thomas Heartman <thomas@getunleash.io>
Date: Mon, 20 Nov 2023 12:28:18 +0100
Subject: [PATCH] feat: lift tests

---
 ...e-request-segment-usage-read-model.test.ts | 134 +++++++++---------
 1 file changed, 64 insertions(+), 70 deletions(-)

diff --git a/src/lib/features/change-request-segment-usage-service/change-request-segment-usage-read-model.test.ts b/src/lib/features/change-request-segment-usage-service/change-request-segment-usage-read-model.test.ts
index 3fae0505bb..f2581c2208 100644
--- a/src/lib/features/change-request-segment-usage-service/change-request-segment-usage-read-model.test.ts
+++ b/src/lib/features/change-request-segment-usage-service/change-request-segment-usage-read-model.test.ts
@@ -134,81 +134,75 @@ describe.each([
     );
 });
 
-describe('addStrategy events should show up in used strategies correctly', () => {
-    test.each([
-        ['Draft', true],
-        ['In review', true],
-        ['Scheduled', true],
-        ['Approved', true],
-        ['Rejected', false],
-        ['Cancelled', false],
-        ['Applied', false],
-    ])(
-        'addStrategy events in %s CRs should show up only of the CR is active',
-        async (state, isActiveCr) => {
-            await createCR(state);
+test.each([
+    ['Draft', true],
+    ['In review', true],
+    ['Scheduled', true],
+    ['Approved', true],
+    ['Rejected', false],
+    ['Cancelled', false],
+    ['Applied', false],
+])(
+    'addStrategy events in %s CRs should show up only of the CR is active',
+    async (state, isActiveCr) => {
+        await createCR(state);
 
-            const segmentId = 3;
+        const segmentId = 3;
 
-            await addStrategyToCr(segmentId, FLAG_NAME);
+        await addStrategyToCr(segmentId, FLAG_NAME);
 
-            const result =
-                await readModel.getStrategiesUsedInActiveChangeRequests(
-                    segmentId,
-                );
-            if (isActiveCr) {
-                expect(result).toStrictEqual([
-                    {
-                        projectId: 'default',
-                        strategyName: 'flexibleRollout',
-                        environment: 'default',
-                        featureName: FLAG_NAME,
-                    },
-                ]);
-            } else {
-                expect(result).toStrictEqual([]);
-            }
-        },
-    );
-});
+        const result = await readModel.getStrategiesUsedInActiveChangeRequests(
+            segmentId,
+        );
+        if (isActiveCr) {
+            expect(result).toStrictEqual([
+                {
+                    projectId: 'default',
+                    strategyName: 'flexibleRollout',
+                    environment: 'default',
+                    featureName: FLAG_NAME,
+                },
+            ]);
+        } else {
+            expect(result).toStrictEqual([]);
+        }
+    },
+);
 
-describe('updateStrategy events should show up in used strategies correctly', () => {
-    test.each([
-        ['Draft', true],
-        ['In review', true],
-        ['Scheduled', true],
-        ['Approved', true],
-        ['Rejected', false],
-        ['Cancelled', false],
-        ['Applied', false],
-    ])(
-        `updateStrategy events in %s CRs should show up only of the CR is active`,
-        async (state, isActiveCr) => {
-            await createCR(state);
+test.each([
+    ['Draft', true],
+    ['In review', true],
+    ['Scheduled', true],
+    ['Approved', true],
+    ['Rejected', false],
+    ['Cancelled', false],
+    ['Applied', false],
+])(
+    `updateStrategy events in %s CRs should show up only of the CR is active`,
+    async (state, isActiveCr) => {
+        await createCR(state);
 
-            const segmentId = 3;
+        const segmentId = 3;
 
-            const strategyId = randomId();
-            await updateStrategyInCr(strategyId, segmentId, FLAG_NAME);
+        const strategyId = randomId();
+        await updateStrategyInCr(strategyId, segmentId, FLAG_NAME);
 
-            const result =
-                await readModel.getStrategiesUsedInActiveChangeRequests(
-                    segmentId,
-                );
+        const result = await readModel.getStrategiesUsedInActiveChangeRequests(
+            segmentId,
+        );
 
-            if (isActiveCr) {
-                expect(result).toMatchObject([
-                    {
-                        id: strategyId,
-                        projectId: 'default',
-                        strategyName: 'flexibleRollout',
-                        environment: 'default',
-                        featureName: FLAG_NAME,
-                    },
-                ]);
-            } else {
-                expect(result).toStrictEqual([]);
-            }
-        },
-    );
-});
+        if (isActiveCr) {
+            expect(result).toMatchObject([
+                {
+                    id: strategyId,
+                    projectId: 'default',
+                    strategyName: 'flexibleRollout',
+                    environment: 'default',
+                    featureName: FLAG_NAME,
+                },
+            ]);
+        } else {
+            expect(result).toStrictEqual([]);
+        }
+    },
+);