From a7aa8b9ad14e4d45aba21dbf7c841e4959233689 Mon Sep 17 00:00:00 2001 From: sjaanus Date: Tue, 9 Aug 2022 07:23:41 +0000 Subject: [PATCH] Remove joins --- src/lib/db/feature-strategy-store.ts | 6 +++--- src/lib/db/feature-toggle-client-store.ts | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/lib/db/feature-strategy-store.ts b/src/lib/db/feature-strategy-store.ts index bd5331c2f6..a3b8e89ef7 100644 --- a/src/lib/db/feature-strategy-store.ts +++ b/src/lib/db/feature-strategy-store.ts @@ -225,12 +225,12 @@ class FeatureStrategiesStore implements IFeatureStrategiesStore { 'feature_strategies.constraints as constraints', 'feature_strategies.sort_order as sort_order', ) - .fullOuterJoin( + .leftJoin( 'feature_environments', 'feature_environments.feature_name', 'features.name', ) - .fullOuterJoin('feature_strategies', function () { + .leftJoin('feature_strategies', function () { this.on( 'feature_strategies.feature_name', '=', @@ -241,7 +241,7 @@ class FeatureStrategiesStore implements IFeatureStrategiesStore { 'feature_environments.environment', ); }) - .fullOuterJoin( + .leftJoin( 'environments', 'feature_environments.environment', 'environments.name', diff --git a/src/lib/db/feature-toggle-client-store.ts b/src/lib/db/feature-toggle-client-store.ts index fce06ce232..f665812559 100644 --- a/src/lib/db/feature-toggle-client-store.ts +++ b/src/lib/db/feature-toggle-client-store.ts @@ -85,7 +85,7 @@ export default class FeatureToggleClientStore let query = this.db('features') .select(selectColumns) .modify(FeatureToggleStore.filterByArchived, archived) - .fullOuterJoin( + .leftJoin( this.db('feature_strategies') .select('*') .where({ environment }) @@ -93,7 +93,7 @@ export default class FeatureToggleClientStore 'fs.feature_name', 'features.name', ) - .fullOuterJoin( + .leftJoin( this.db('feature_environments') .select('feature_name', 'enabled', 'environment') .where({ environment })