diff --git a/frontend/src/component/insights/calculate-ratio/calculate-ratio.test.ts b/frontend/src/component/insights/calculate-ratio/calculate-ratio.test.ts index 61548cd669..39c92b95e5 100644 --- a/frontend/src/component/insights/calculate-ratio/calculate-ratio.test.ts +++ b/frontend/src/component/insights/calculate-ratio/calculate-ratio.test.ts @@ -1,17 +1,17 @@ import { calculateRatio } from './calculate-ratio.ts'; -test('A ratio of anything to 0 is 100', () => { - expect(calculateRatio(0, 0)).toBe(100); - expect(calculateRatio(5, 0)).toBe(100); +test('A ratio of anything to 0 is N/A', () => { + expect(calculateRatio(0, 0)).toBe('N/A'); + expect(calculateRatio(5, 0)).toBe('N/A'); }); test('Normal ratios work as expected', () => { - expect(calculateRatio(0, 1)).toBe(0); - expect(calculateRatio(1, 1)).toBe(100); - expect(calculateRatio(1, 2)).toBe(50); - expect(calculateRatio(5, 2)).toBe(250); + expect(calculateRatio(0, 1)).toBe('0%'); + expect(calculateRatio(1, 1)).toBe('100%'); + expect(calculateRatio(1, 2)).toBe('50%'); + expect(calculateRatio(5, 2)).toBe('250%'); }); test('Numbers are rounded to the nearest integer', () => { - expect(calculateRatio(5, 9)).toBe(56); + expect(calculateRatio(5, 9)).toBe('56%'); }); diff --git a/frontend/src/component/insights/calculate-ratio/calculate-ratio.ts b/frontend/src/component/insights/calculate-ratio/calculate-ratio.ts index ad5e1066a6..b80875bf84 100644 --- a/frontend/src/component/insights/calculate-ratio/calculate-ratio.ts +++ b/frontend/src/component/insights/calculate-ratio/calculate-ratio.ts @@ -1,12 +1,11 @@ export const calculateRatio = ( antecedent: number, consequent: number, -): number => { - const rawRatio = Math.round((antecedent / consequent) * 100); - - if (Number.isNaN(rawRatio) || rawRatio === Number.POSITIVE_INFINITY) { - return 100; +): string => { + if (consequent === 0) { + return 'N/A'; } + const ratio = Math.round((antecedent / consequent) * 100); - return rawRatio; + return `${ratio}%`; }; diff --git a/frontend/src/component/insights/componentsChart/CreationArchiveChart/CreationArchiveRatioTooltip.tsx b/frontend/src/component/insights/componentsChart/CreationArchiveChart/CreationArchiveRatioTooltip.tsx index 721ea7385a..29eb897a4e 100644 --- a/frontend/src/component/insights/componentsChart/CreationArchiveChart/CreationArchiveRatioTooltip.tsx +++ b/frontend/src/component/insights/componentsChart/CreationArchiveChart/CreationArchiveRatioTooltip.tsx @@ -62,7 +62,7 @@ export const CreationArchiveRatioTooltip: FC< fontWeight='bold' sx={{ marginBottom: 1 }} > - Ratio {ratio}% + Ratio {ratio} diff --git a/frontend/src/component/insights/componentsStat/CreationArchiveStats/CreationArchiveStats.tsx b/frontend/src/component/insights/componentsStat/CreationArchiveStats/CreationArchiveStats.tsx index 6c9a2251c1..a674165dfe 100644 --- a/frontend/src/component/insights/componentsStat/CreationArchiveStats/CreationArchiveStats.tsx +++ b/frontend/src/component/insights/componentsStat/CreationArchiveStats/CreationArchiveStats.tsx @@ -90,7 +90,7 @@ export const CreationArchiveStats: FC = ({ - {isLoading ? '...' : `${currentRatio}%`} + {isLoading ? '...' : currentRatio} diff --git a/frontend/src/component/insights/sections/PerformanceInsights.tsx b/frontend/src/component/insights/sections/PerformanceInsights.tsx index e19f9abd64..4e1caf9ba1 100644 --- a/frontend/src/component/insights/sections/PerformanceInsights.tsx +++ b/frontend/src/component/insights/sections/PerformanceInsights.tsx @@ -113,7 +113,7 @@ export const PerformanceInsights: FC = () => { {isLifecycleGraphsEnabled && isEnterprise() ? ( - +