From a8d34d62689ae0536d29af75474d09ce22cac4fb Mon Sep 17 00:00:00 2001
From: olav <mail@olav.io>
Date: Fri, 20 May 2022 11:07:30 +0200
Subject: [PATCH] fix: the replaceGroupId field should be optional (#1608)

---
 src/lib/openapi/spec/clone-feature-schema.ts                    | 2 +-
 src/lib/routes/admin-api/project/features.ts                    | 2 +-
 src/test/e2e/api/openapi/__snapshots__/openapi.e2e.test.ts.snap | 1 -
 3 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/lib/openapi/spec/clone-feature-schema.ts b/src/lib/openapi/spec/clone-feature-schema.ts
index c8901031a8..294e5a7c9b 100644
--- a/src/lib/openapi/spec/clone-feature-schema.ts
+++ b/src/lib/openapi/spec/clone-feature-schema.ts
@@ -2,7 +2,7 @@ import { createSchemaObject, CreateSchemaType } from '../types';
 
 const schema = {
     type: 'object',
-    required: ['name', 'replaceGroupId'],
+    required: ['name'],
     properties: {
         name: {
             type: 'string',
diff --git a/src/lib/routes/admin-api/project/features.ts b/src/lib/routes/admin-api/project/features.ts
index de523839eb..bcbb264645 100644
--- a/src/lib/routes/admin-api/project/features.ts
+++ b/src/lib/routes/admin-api/project/features.ts
@@ -359,7 +359,7 @@ export default class ProjectFeaturesController extends Controller {
             featureName,
             projectId,
             name,
-            Boolean(replaceGroupId),
+            replaceGroupId,
             userName,
         );
         res.status(201).json(created);
diff --git a/src/test/e2e/api/openapi/__snapshots__/openapi.e2e.test.ts.snap b/src/test/e2e/api/openapi/__snapshots__/openapi.e2e.test.ts.snap
index 002e5f3283..ba58315f0b 100644
--- a/src/test/e2e/api/openapi/__snapshots__/openapi.e2e.test.ts.snap
+++ b/src/test/e2e/api/openapi/__snapshots__/openapi.e2e.test.ts.snap
@@ -62,7 +62,6 @@ Object {
         },
         "required": Array [
           "name",
-          "replaceGroupId",
         ],
         "type": "object",
       },