From a991cf4eff109cb03ad37bdb1da465c6af514b5f Mon Sep 17 00:00:00 2001 From: Jaanus Sellin Date: Fri, 11 Oct 2024 14:33:46 +0300 Subject: [PATCH] fix: now health widget will match will chart (#8432) Now it will match with chart if no data. Previous ![image](https://github.com/user-attachments/assets/48d9c19b-962f-45b9-ab6e-defacd53d90e) Now ![image](https://github.com/user-attachments/assets/f0132890-9491-4f0e-a88b-e5444ca3eb6b) --- .../component/insights/hooks/useFilteredFlagsSummary.test.ts | 4 ++-- .../src/component/insights/hooks/useFilteredFlagsSummary.ts | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/frontend/src/component/insights/hooks/useFilteredFlagsSummary.test.ts b/frontend/src/component/insights/hooks/useFilteredFlagsSummary.test.ts index ca10cfc0e7..e02615ddf7 100644 --- a/frontend/src/component/insights/hooks/useFilteredFlagsSummary.test.ts +++ b/frontend/src/component/insights/hooks/useFilteredFlagsSummary.test.ts @@ -161,7 +161,7 @@ describe('useFilteredFlagTrends', () => { stale: 0, potentiallyStale: 0, averageUsers: 0, - averageHealth: undefined, + averageHealth: '100', medianTimeToProduction: undefined, }); }); @@ -214,7 +214,7 @@ describe('useFilteredFlagTrends', () => { stale: 0, potentiallyStale: 0, averageUsers: 0, - averageHealth: undefined, + averageHealth: '100', medianTimeToProduction: 5, }); }); diff --git a/frontend/src/component/insights/hooks/useFilteredFlagsSummary.ts b/frontend/src/component/insights/hooks/useFilteredFlagsSummary.ts index 7b428629d0..3ff263aea7 100644 --- a/frontend/src/component/insights/hooks/useFilteredFlagsSummary.ts +++ b/frontend/src/component/insights/hooks/useFilteredFlagsSummary.ts @@ -70,7 +70,7 @@ export const useFilteredFlagsSummary = ( averageUsers, averageHealth: sum.total ? ((sum.active / (sum.total || 1)) * 100).toFixed(0) - : undefined, + : '100', medianTimeToProduction, }; }, [filteredProjectFlagTrends]);