Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-01-11 00:08:30 +01:00
Code Issues Projects Releases Wiki Activity

fix: typo and improved example in latest ADR (#8063)

Browse Source 
https://github.com/Unleash/unleash/pull/8025#discussion_r1740561994
This commit is contained in:
Tymoteusz Czech 2024-09-19 14:44:16 +02:00 committed by GitHub
parent 95969456f6
commit aa7757a2d1
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
website/docs/contributing/ADRs/front-end/jsx-conditionals.md
View File

@ -67,6 +67,16 @@ Nested ternaries are easier to spot than nested `<ConditionallyRender />` elemen
</div> </div>
``` ```
Nested operator does not look like other JSX components.
```tsx
<div>
{a ? (
b ? <p>This is bad</p> : null
) : 'Should be refactored'}
</div>
```
## Options considered ## Options considered
To avoid these issues, safer alternatives to the `&&` operator can be used: To avoid these issues, safer alternatives to the `&&` operator can be used:
@ -118,4 +128,4 @@ There already is a script developed that can convert files between `Conditionall
4. More complex and critical pages, like strategy editing. 4. More complex and critical pages, like strategy editing.
5. Utilities and components used in many places (`/src/component/common`). 5. Utilities and components used in many places (`/src/component/common`).
3. Once all instances of `<ConditionallyRender />` have been refactored, remove the component from the codebase. 4. Once all instances of `<ConditionallyRender />` have been refactored, remove the component from the codebase.