Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-02-04 00:18:01 +01:00
Code Issues Projects Releases Wiki Activity

fix: hide password login when it's disabled (#3851)

Browse Source 
https://linear.app/unleash/issue/2-1085/bug-password-based-login-still-shows-on-the-login-page-even-if

Fixes a regression introduced with the changes related with #3633 where
we still show the password login even though it's disabled.

---------

Co-authored-by: Thomas Heartman <thomas@getunleash.io>
This commit is contained in:
Nuno Góis 2023-05-24 09:39:24 +01:00 committed by GitHub
parent 540c5f2cc5
commit ab4ff29407
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/lib/error/unleash-error.test.ts
View File

@ -374,6 +374,7 @@ describe('Error serialization special cases', () => {
type: 'password', type: 'password',
path: `base-path/auth/simple/login`, path: `base-path/auth/simple/login`,
message: 'You must sign in order to use Unleash', message: 'You must sign in order to use Unleash',
defaultHidden: true,
options: [ options: [
{ {
type: 'google', type: 'google',

1
src/lib/types/authentication-required.ts
View File

@ -39,6 +39,7 @@ class AuthenticationRequired extends UnleashError {
...super.toJSON(), ...super.toJSON(),
path: this.path, path: this.path,
type: this.type, type: this.type,
defaultHidden: this.defaultHidden,
...(this.options ? { options: this.options } : {}), ...(this.options ? { options: this.options } : {}),
}; };
} }