chore: remove registerFrontendClient flag ws-swe1 [keep]

frontend/src/component/application/ApplicationChart.tsx

@@ -2,7 +2,7 @@ import { Box, Divider, styled, Typography, useTheme } from '@mui/material';
 import { ArcherContainer, ArcherElement } from 'react-archer';
 import { useNavigate } from 'react-router-dom';
 import type React from 'react';
-import { type FC, useLayoutEffect, useRef, useState } from 'react';
+import { useRef, useState, useLayoutEffect } from 'react';
 import type {
     ApplicationOverviewEnvironmentSchema,
     ApplicationOverviewSchema,
@@ -16,7 +16,6 @@ import WarningAmberRounded from '@mui/icons-material/WarningAmberRounded';
 import { TimeAgo } from 'component/common/TimeAgo/TimeAgo';
 import { usePlausibleTracker } from 'hooks/usePlausibleTracker';
 import { getApplicationIssues } from './ApplicationIssues/ApplicationIssues.tsx';
-import { useUiFlag } from 'hooks/useUiFlag';
 
 const StyledTable = styled('table')(({ theme }) => ({
     fontSize: theme.fontSizes.smallerBody,
@@ -141,7 +140,7 @@ const SuccessStatus = () => (
     </StyledStatus>
 );
 
-const WarningStatus: FC<{ children?: React.ReactNode }> = ({ children }) => (
+const WarningStatus = ({ children }: { children?: React.ReactNode }) => (
     <StyledStatus mode='warning'>
         <WarningAmberRounded
             sx={(theme) => ({
@@ -197,8 +196,6 @@ export const ApplicationChart = ({ data }: IApplicationChartProps) => {
     const { elementRef, width } = useElementWidth();
     const navigate = useNavigate();
     const theme = useTheme();
-    const registerFrontendClientEnabled = useUiFlag('registerFrontendClient');
-
     const mode = getApplicationIssues(data);
 
     return (
@@ -296,23 +293,7 @@ export const ApplicationChart = ({ data }: IApplicationChartProps) => {
                                                 {environment.instanceCount}
                                             </StyledCell>
                                         </tr>
-                                        {!registerFrontendClientEnabled ? (
+                                        {environment.backendSdks.length > 0 && (
-                                            <tr>
-                                                <StyledCell>SDK:</StyledCell>
-                                                <StyledCell>
-                                                    {environment.sdks.map(
-                                                        (sdk) => (
-                                                            <div key={sdk}>
-                                                                {sdk}
-                                                            </div>
-                                                        ),
-                                                    )}
-                                                </StyledCell>
-                                            </tr>
-                                        ) : null}
-
-                                        {registerFrontendClientEnabled &&
-                                        environment.backendSdks.length > 0 ? (
                                             <tr>
                                                 <StyledCell>
                                                     Backend SDK:
@@ -327,10 +308,10 @@ export const ApplicationChart = ({ data }: IApplicationChartProps) => {
                                                     )}
                                                 </StyledCell>
                                             </tr>
-                                        ) : null}
+                                        )}
 
-                                        {registerFrontendClientEnabled &&
+                                        {environment.frontendSdks.length >
-                                        environment.frontendSdks.length > 0 ? (
+                                            0 && (
                                             <tr>
                                                 <StyledCell>
                                                     Frontend SDK:
@@ -345,7 +326,7 @@ export const ApplicationChart = ({ data }: IApplicationChartProps) => {
                                                     )}
                                                 </StyledCell>
                                             </tr>
-                                        ) : null}
+                                        )}
 
                                         <tr>
                                             <StyledCell>Last seen:</StyledCell>

frontend/src/interfaces/uiConfig.ts

@@ -85,7 +85,6 @@ export type UiFlags = {
     showUserDeviceCount?: boolean;
     consumptionModel?: boolean;
     edgeObservability?: boolean;
-    registerFrontendClient?: boolean;
     customMetrics?: boolean;
     lifecycleMetrics?: boolean;
     createFlagDialogCache?: boolean;

src/lib/features/frontend-api/frontend-api-service.ts

@@ -135,11 +135,7 @@ export class FrontendApiService {
             ip,
         );
 
-        if (
+        if (metrics.instanceId && typeof sdkVersion === 'string') {
-            metrics.instanceId &&
-            typeof sdkVersion === 'string' &&
-            this.flagResolver.isEnabled('registerFrontendClient')
-        ) {
             const client = {
                 appName: metrics.appName,
                 instanceId: metrics.instanceId,

src/lib/features/metrics/instance/metrics.test.ts

@@ -45,13 +45,7 @@ let services: IUnleashServices;
 let destroy: () => Promise<void>;
 
 beforeAll(async () => {
-    const setup = await getSetup({
+    const setup = await getSetup();
-        experimental: {
-            flags: {
-                registerFrontendClient: true,
-            },
-        },
-    });
     request = setup.request;
     stores = setup.stores;
     destroy = setup.destroy;

src/lib/features/metrics/instance/metrics.ts

@@ -226,20 +226,14 @@ export default class ClientMetricsController extends Controller {
                         app.sdkType === 'frontend' &&
                         typeof app.sdkVersion === 'string'
                     ) {
-                        if (
+                        this.clientInstanceService.registerFrontendClient({
-                            this.flagResolver.isEnabled(
+                            appName: app.appName,
-                                'registerFrontendClient',
+                            instanceId: app.instanceId,
-                            )
+                            environment: app.environment,
-                        ) {
+                            sdkType: app.sdkType,
-                            this.clientInstanceService.registerFrontendClient({
+                            sdkVersion: app.sdkVersion,
-                                appName: app.appName,
+                            projects: app.projects,
-                                instanceId: app.instanceId,
+                        });
-                                environment: app.environment,
-                                sdkType: app.sdkType,
-                                sdkVersion: app.sdkVersion,
-                                projects: app.projects,
-                            });
-                        }
                     } else {
                         promises.push(
                             this.clientInstanceService.registerBackendClient(

src/lib/types/experimental.ts

@@ -55,7 +55,6 @@ export type IFlagKey =
     | 'uniqueSdkTracking'
     | 'consumptionModel'
     | 'edgeObservability'
-    | 'registerFrontendClient'
     | 'reportUnknownFlags'
     | 'lastSeenBulkQuery'
     | 'lifecycleMetrics'
@@ -264,10 +263,6 @@ const flags: IFlags = {
         process.env.EXPERIMENTAL_EDGE_OBSERVABILITY,
         false,
     ),
-    registerFrontendClient: parseEnvVarBoolean(
-        process.env.UNLEASH_EXPERIMENTAL_REGISTER_FRONTEND_CLIENT,
-        false,
-    ),
     reportUnknownFlags: parseEnvVarBoolean(
         process.env.UNLEASH_EXPERIMENTAL_REPORT_UNKNOWN_FLAGS,
         false,

src/server-dev.ts

@@ -51,7 +51,6 @@ process.nextTick(async () => {
                         deltaApi: true,
                         uniqueSdkTracking: true,
                         strictSchemaValidation: true,
-                        registerFrontendClient: true,
                         reportUnknownFlags: true,
                         customMetrics: true,
                         lifecycleMetrics: true,

src/test/e2e/api/admin/applications.e2e.test.ts

@@ -55,7 +55,6 @@ beforeAll(async () => {
             experimental: {
                 flags: {
                     strictSchemaValidation: true,
-                    registerFrontendClient: true,
                 },
             },
         },