Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-03-04 00:18:40 +01:00
Code Issues Projects Releases Wiki Activity

manual fix lint errors

Browse Source
This commit is contained in:
sveisvei 2016-06-18 22:23:19 +02:00
parent 61532301fb
commit acc46c6221
17 changed files with 90 additions and 95 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/unleash-api/app.js
View File

@ -11,7 +11,7 @@ const path = require('path');
module.exports = function(config) {
const app = express();
const router = express.Router();
const router = express.Router(); // eslint-disable-line new-cap
const baseUriPath = config.baseUriPath || '';
const publicFolder = config.publicFolder;

2
packages/unleash-api/lib/db/event.js
View File

@ -22,7 +22,7 @@ module.exports = function(db) {
return db
.select(EVENT_COLUMNS)
.from('events')
.whereRaw('data ->> \'name\' = ?', [name])
.whereRaw('data ->> "name" = ?', [name])
.orderBy('created_at', 'desc')
.map(rowToEvent);
}

11
packages/unleash-api/lib/eventDiffer.js
View File

@ -19,9 +19,8 @@ function baseTypeFor(event) {
return 'features';
} else if (strategyTypes.indexOf(event.type) !== -1) {
return 'strategies';
} else {
throw new Error(`unknown event type: ${JSON.stringify(event)}`);
}
throw new Error(`unknown event type: ${JSON.stringify(event)}`);
}
function groupByBaseTypeAndName(events) {
@ -46,14 +45,14 @@ function eachConsecutiveEvent(events, callback) {
const group = groups[baseType];
Object.keys(group).forEach(name => {
const events = group[name];
const currentEvents = group[name];
let left;
let right;
let i;
let l;
for (i = 0, l = events.length; i < l; i++) {
left = events[i];
right = events[i + 1];
for (i = 0, l = currentEvents.length; i < l; i++) {
left = currentEvents[i];
right = currentEvents[i + 1];
callback(left, right);
}

3
packages/unleash-api/lib/eventStore.js
View File

@ -9,9 +9,8 @@ function EventStore(eventDb) {
util.inherits(EventStore, EventEmitter);
EventStore.prototype.create = function (event) {
const that = this;
return this.eventDb.store(event).then(() => {
that.emit(event.type, event);
this.emit(event.type, event);
});
};

4
packages/unleash-api/scripts/migration-runner.js
View File

@ -3,8 +3,8 @@ const fs = require('fs');
const util = require('util');
const path = require('path');
const runMigration = function(path, db, callback) {
db.runSql(fs.readFileSync(path, { encoding: 'utf8' }), callback);
const runMigration = function(migrationPath, db, callback) {
db.runSql(fs.readFileSync(migrationPath, { encoding: 'utf8' }), callback);
};
module.exports = {

23
packages/unleash-frontend/public/js/__tests__/components/feature/FeatureList-test.js
View File

@ -8,10 +8,9 @@ const FeatureList = require('../../../components/feature/FeatureList');
describe('FeatureList', () => {
let Component;
let features;
beforeEach(() => {
features = [
const features = [
{ name: 'featureX', strategy: 'other' },
{ name: 'group.featureY', strategy: 'default' },
];
@ -26,25 +25,25 @@ describe('FeatureList', () => {
});
it('should render all features', () => {
const features = Component.getDOMNode().querySelectorAll('.feature');
expect(features.length).toEqual(2);
const featuresElement = Component.getDOMNode().querySelectorAll('.feature');
expect(featuresElement.length).toEqual(2);
});
it('should filter list of features', () => {
const filterNode = Component.refs.filter.getDOMNode();
TestUtils.Simulate.change(filterNode, { target: { value: 'group' } });
const features = Component.getDOMNode().querySelectorAll('.feature');
expect(features.length).toEqual(1);
const featuresElement = Component.getDOMNode().querySelectorAll('.feature');
expect(featuresElement.length).toEqual(1);
});
it('should filter list of features ignoring case', () => {
const filterNode = Component.refs.filter.getDOMNode();
TestUtils.Simulate.change(filterNode, { target: { value: 'GROUP' } });
const features = Component.getDOMNode().querySelectorAll('.feature');
expect(features.length).toEqual(1);
expect(features[0].textContent).toMatch('group');
const featuresElement = Component.getDOMNode().querySelectorAll('.feature');
expect(featuresElement.length).toEqual(1);
expect(featuresElement[0].textContent).toMatch('group');
});
it('should filter list of features by strategy name', () => {
@ -52,8 +51,8 @@ describe('FeatureList', () => {
const filterNode = Component.refs.filter.getDOMNode();
TestUtils.Simulate.change(filterNode, { target: { value: searchString } });
const features = Component.getDOMNode().querySelectorAll('.feature');
expect(features.length).toEqual(1);
expect(features[0].textContent).toMatch(searchString);
const featuresElement = Component.getDOMNode().querySelectorAll('.feature');
expect(featuresElement.length).toEqual(1);
expect(featuresElement[0].textContent).toMatch(searchString);
});
});

2
packages/unleash-frontend/public/js/components/ErrorMessages.jsx
View File

@ -31,7 +31,7 @@ const ErrorMessages = React.createClass({
render() {
return (
<Ui errors={this.state.errors} onClearErrors={this.onClearErrors}></Ui>
<Ui errors={this.state.errors} onClearErrors={this.onClearErrors} />
);
},
});

3
packages/unleash-frontend/public/js/components/Menu.jsx
View File

@ -3,7 +3,8 @@ const React = require('react');
const User = require('./User');
const Menu = React.createClass({
render() { return (
render() {
return (
<div className="topbar mbl">
<div className="container">
<div className="page">

2
packages/unleash-frontend/public/js/components/feature/Feature.jsx
View File

@ -33,7 +33,7 @@ const Feature = React.createClass({
},
archiveFeature() {
if (window.confirm(`Are you sure you want to delete ${this.props.feature.name}?`)) {
if (window.confirm(`Are you sure you want to delete ${this.props.feature.name}?`)) { // eslint-disable-line no-alert
this.props.onArchive(this.props.feature);
}
},

5
packages/unleash-frontend/public/js/components/feature/FeatureForm.jsx
View File

@ -25,9 +25,8 @@ const FeatureForm = React.createClass({
getParameterValue(name) {
if (this.props.feature && this.props.feature.parameters) {
return this.props.feature.parameters[name];
} else {
return '';
}
return '';
},
setSelectedStrategy(name) {
@ -47,8 +46,10 @@ const FeatureForm = React.createClass({
const requiredParams = [];
let key;
for (key in strategy.parametersTemplate) {
if (Object.hasOwnProperty.call(strategy.parametersTemplate, key)) {
requiredParams.push({ name: key, value: this.getParameterValue(key) });
}
}
this.setState({ requiredParams });
},

3
packages/unleash-frontend/public/js/components/feature/FeatureList.jsx
View File

@ -33,9 +33,8 @@ const FeatureList = React.createClass({
const regex = new RegExp(this.state.filter, 'i');
return this.props.features.filter(item => regex.test(item.name) || regex.test(item.strategy));
} else {
return this.props.features;
}
return this.props.features;
},
render() {

3
packages/unleash-frontend/public/js/components/log/LogEntry.jsx
View File

@ -57,9 +57,8 @@ const LogEntry = React.createClass({
return (
<code className="smalltext man">{changes.length === 0 ? '(no changes)' : changes}</code>
);
} else {
return this.renderFullEventData();
}
return this.renderFullEventData();
},
buildDiff(diff, idx) {

2
packages/unleash-frontend/public/js/components/strategy/Strategy.jsx
View File

@ -8,7 +8,7 @@ const Strategy = React.createClass({
onRemove(event) {
event.preventDefault();
if (window.confirm(`Are you sure you want to delete strategy '${this.props.strategy.name}'?`)) {
if (window.confirm(`Are you sure you want to delete strategy '${this.props.strategy.name}'?`)) { // eslint-disable-line no-alert
this.props.onRemove(this.props.strategy);
}
},

4
packages/unleash-frontend/public/js/components/strategy/StrategyForm.jsx
View File

@ -24,10 +24,8 @@ const StrategyForm = React.createClass({
strategy.description = this.refs.description.getValue();
strategy.parametersTemplate = {};
const that = this;
this.state.parameters.forEach(parameter => {
const name = that.refs[parameter.name].getDOMNode().value.trim();
const name = this.refs[parameter.name].getDOMNode().value.trim();
if (name) {
strategy.parametersTemplate[name] = 'string';
}

2
packages/unleash-frontend/public/js/stores/ErrorStore.js
View File

@ -52,7 +52,7 @@ const FeatureStore = Reflux.createStore({
} catch (e) {
if (e instanceof SyntaxError) {
// fall through;
console.log('Syntax error!');
console.log('Syntax error!'); // eslint-disable-line no-console
} else {
throw e;
}

2
packages/unleash-frontend/public/js/stores/UserStore.js
View File

@ -7,7 +7,7 @@ function readCookie(name) {
const ca = document.cookie.split(';');
for (let i=0;i < ca.length;i++) {
let c = ca[i];
while (c.charAt(0)==' ') {
while (c.charAt(0)==' ') { // eslint-disable-line eqeqeq
c = c.substring(1, c.length);
}
if (c.indexOf(nameEQ) === 0) {

8
packages/unleash-frontend/public/js/utils/Timer.js
View File

@ -7,19 +7,19 @@ const Timer = function(cb, interval) {
Timer.prototype.start = function() {
if (this.timerId != null) {
console.warn('timer already started');
console.warn('timer already started'); // eslint-disable-line no-console
}
console.log('starting timer');
console.log('starting timer'); // eslint-disable-line no-console
this.timerId = setInterval(this.cb, this.interval);
this.cb();
};
Timer.prototype.stop = function() {
if (this.timerId == null) {
console.warn('no timer running');
console.warn('no timer running'); // eslint-disable-line no-console
} else {
console.log('stopping timer');
console.log('stopping timer'); // eslint-disable-line no-console
clearInterval(this.timerId);
this.timerId = null;
}