Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-02-23 00:22:19 +01:00
Code Issues Projects Releases Wiki Activity

refactor: move message banner interface to common file (#5076)

Browse Source 
https://linear.app/unleash/issue/2-1527/set-up-message-banner-interfaces

Tiny refactor to move the message banner interface to its own file,
since it will be used in multiple places.
This commit is contained in:
Nuno Góis 2023-10-18 10:32:19 +01:00 committed by GitHub
parent 3ac8ab898a
commit ad7149f26f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 22 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
frontend/src/component/messageBanners/MessageBanner/MessageBanner.tsx
View File

@ -10,6 +10,7 @@ import { useNavigate } from 'react-router-dom';
import { MessageBannerDialog } from './MessageBannerDialog/MessageBannerDialog'; import { MessageBannerDialog } from './MessageBannerDialog/MessageBannerDialog';
import { useState } from 'react'; import { useState } from 'react';
import ReactMarkdown from 'react-markdown'; import ReactMarkdown from 'react-markdown';
import { BannerVariant, IMessageBanner } from 'interfaces/messageBanner';
const StyledBar = styled('aside', { const StyledBar = styled('aside', {
shouldForwardProp: (prop) => prop !== 'variant' && prop !== 'sticky', shouldForwardProp: (prop) => prop !== 'variant' && prop !== 'sticky',
@ -42,20 +43,6 @@ const StyledIcon = styled('div', {
color: theme.palette[variant].main, color: theme.palette[variant].main,
})); }));
type BannerVariant = 'warning' | 'info' | 'error' | 'success';
export interface IMessageBanner {
message: string;
variant?: BannerVariant;
sticky?: boolean;
icon?: string;
link?: string;
linkText?: string;
plausibleEvent?: string;
dialogTitle?: string;
dialog?: string;
}
interface IMessageBannerProps { interface IMessageBannerProps {
messageBanner: IMessageBanner; messageBanner: IMessageBanner;
} }

6
frontend/src/component/messageBanners/externalMessageBanners/ExternalMessageBanners.tsx
View File

@ -1,9 +1,7 @@
import { import { MessageBanner } from 'component/messageBanners/MessageBanner/MessageBanner';
IMessageBanner,
MessageBanner,
} from 'component/messageBanners/MessageBanner/MessageBanner';
import useUiConfig from 'hooks/api/getters/useUiConfig/useUiConfig'; import useUiConfig from 'hooks/api/getters/useUiConfig/useUiConfig';
import { useVariant } from 'hooks/useVariant'; import { useVariant } from 'hooks/useVariant';
import { IMessageBanner } from 'interfaces/messageBanner';
export const ExternalMessageBanners = () => { export const ExternalMessageBanners = () => {
const { uiConfig } = useUiConfig(); const { uiConfig } = useUiConfig();

19
frontend/src/interfaces/messageBanner.ts Normal file
View File

@ -0,0 +1,19 @@
export type BannerVariant = 'warning' | 'info' | 'error' | 'success';
export interface IMessageBanner {
message: string;
variant?: BannerVariant;
sticky?: boolean;
icon?: string;
link?: string;
linkText?: string;
plausibleEvent?: string;
dialogTitle?: string;
dialog?: string;
}
export interface IInternalMessageBanner extends IMessageBanner {
id: number;
enabled: boolean;
createdAt: string;
}