From aea2f613dfdc8b9f7cd57f4df242dcf8cf17fca5 Mon Sep 17 00:00:00 2001 From: andreas-unleash Date: Thu, 21 Mar 2024 11:35:49 +0200 Subject: [PATCH] fix: N/A only on NaN Signed-off-by: andreas-unleash --- .../hooks/useFilteredFlagsSummary.test.ts | 2 +- .../hooks/useFilteredFlagsSummary.ts | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/frontend/src/component/executiveDashboard/hooks/useFilteredFlagsSummary.test.ts b/frontend/src/component/executiveDashboard/hooks/useFilteredFlagsSummary.test.ts index 5da2af3f7f..f834c87c6e 100644 --- a/frontend/src/component/executiveDashboard/hooks/useFilteredFlagsSummary.test.ts +++ b/frontend/src/component/executiveDashboard/hooks/useFilteredFlagsSummary.test.ts @@ -159,7 +159,7 @@ describe('useFilteredFlagTrends', () => { potentiallyStale: 0, averageUsers: 0, averageHealth: undefined, - flagsPerUser: 'N/A', + flagsPerUser: '0.0', }); }); }); diff --git a/frontend/src/component/executiveDashboard/hooks/useFilteredFlagsSummary.ts b/frontend/src/component/executiveDashboard/hooks/useFilteredFlagsSummary.ts index 6e6ece31d0..9cd0c04d8b 100644 --- a/frontend/src/component/executiveDashboard/hooks/useFilteredFlagsSummary.ts +++ b/frontend/src/component/executiveDashboard/hooks/useFilteredFlagsSummary.ts @@ -42,14 +42,14 @@ export const useFilteredFlagsSummary = ( }, ); - const flagsPerUser = users?.total ? sum.total / users.total : 0; + const flagsPerUserCalculation = sum.total / users.total; + const flagsPerUser = Number.isNaN(flagsPerUserCalculation) + ? 'N/A' + : flagsPerUserCalculation.toFixed(1); return { ...sum, - flagsPerUser: - Number.isNaN(flagsPerUser) || flagsPerUser === 0 - ? 'N/A' - : flagsPerUser.toFixed(1), + flagsPerUser, averageUsers, averageHealth: sum.total ? ((sum.active / (sum.total || 1)) * 100).toFixed(0)