Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-09-05 17:53:12 +02:00
Code Issues Projects Releases Wiki Activity

feat: cleanup

Browse Source
This commit is contained in:
Thomas Heartman 2023-11-23 14:16:39 +01:00
parent 2b46a21f21
commit af23c0df39
No known key found for this signature in database
GPG Key ID: BD1F880DAED1EE78
1 changed files with 5 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
frontend/src/component/segments/SegmentDelete/SegmentDeleteUsedSegment/sort-strategies.ts
View File

@ -13,7 +13,7 @@ export const sortStrategiesByFeature = <
strategies: ExistingStrategy[], strategies: ExistingStrategy[],
changeRequestStrategies: (UpdatedStrategy | NewStrategy)[], changeRequestStrategies: (UpdatedStrategy | NewStrategy)[],
): (ExistingStrategy | UpdatedStrategy | NewStrategy)[] => { ): (ExistingStrategy | UpdatedStrategy | NewStrategy)[] => {
const collected = [...strategies, ...changeRequestStrategies].reduce( const strategiesByFlag = [...strategies, ...changeRequestStrategies].reduce(
(acc, strategy) => { (acc, strategy) => {
if (!strategy.featureName) { if (!strategy.featureName) {
// this shouldn't ever happen here, but because the // this shouldn't ever happen here, but because the
@ -39,19 +39,17 @@ export const sortStrategiesByFeature = <
}, },
); );
const flags: [ const flagToStrategiesList = Object.entries(strategiesByFlag);
string,
(ExistingStrategy | UpdatedStrategy | NewStrategy)[],
][] = Object.entries(collected);
flags.sort(([flagA], [flagB]) => { flagToStrategiesList.sort(([flagA], [flagB]) => {
return flagA.localeCompare(flagB); return flagA.localeCompare(flagB);
}); });
return flags.flatMap(([_, strategies]) => { return flagToStrategiesList.flatMap(([_, strategies]) => {
const isExistingStrategy = ( const isExistingStrategy = (
strategy: ExistingStrategy | UpdatedStrategy | NewStrategy, strategy: ExistingStrategy | UpdatedStrategy | NewStrategy,
): strategy is ExistingStrategy | UpdatedStrategy => 'id' in strategy; ): strategy is ExistingStrategy | UpdatedStrategy => 'id' in strategy;
const isChangeRequest = ( const isChangeRequest = (
strategy: ExistingStrategy | UpdatedStrategy | NewStrategy, strategy: ExistingStrategy | UpdatedStrategy | NewStrategy,
): strategy is UpdatedStrategy | NewStrategy => ): strategy is UpdatedStrategy | NewStrategy =>
@ -92,20 +90,3 @@ export const sortStrategiesByFeature = <
return strategies; return strategies;
}); });
}; };
export const sortAndFlattenStrategies = <
T extends { id: string; featureName?: string },
U extends {
id?: string;
featureName: string;
changeRequest: { id: number };
},
>(
strategies: T[],
changeRequestStrategies: U[],
): (T | U)[] => {
const sorted = sortStrategiesByFeature(strategies, changeRequestStrategies);
// flatten list of
return Object.values(sorted).flat();
};