Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-02-09 00:18:00 +01:00
Code Issues Projects Releases Wiki Activity

fix: return if empty array (#9254)

Browse Source 
Fixes an issue where segment-updated event would be added to cache even
though there were no correlated events. Tests needs to be added in
Enterprise.
This commit is contained in:
Fredrik Strand Oseberg 2025-02-07 14:39:43 +01:00 committed by GitHub
parent aa5c70f70e
commit af516537bd
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/lib/features/client-feature-toggles/delta/client-feature-toggle-delta.ts
View File

@ -171,6 +171,7 @@ export class ClientFeatureToggleDelta extends EventEmitter {
if (!hasDelta) { if (!hasDelta) {
await this.initEnvironmentDelta(environment); await this.initEnvironmentDelta(environment);
} }
if (requiredRevisionId >= this.currentRevisionId) { if (requiredRevisionId >= this.currentRevisionId) {
return undefined; return undefined;
} }
@ -272,7 +273,7 @@ export class ClientFeatureToggleDelta extends EventEmitter {
.map((event) => event.preData.id); .map((event) => event.preData.id);
const segments = const segments =
await this.segmentReadModel.getAllForClient(segmentsUpdated); await this.segmentReadModel.getAllForClientIds(segmentsUpdated);
const segmentsUpdatedEvents: DeltaEvent[] = segments.map((segment) => ({ const segmentsUpdatedEvents: DeltaEvent[] = segments.map((segment) => ({
eventId: latestRevision, eventId: latestRevision,
@ -328,7 +329,7 @@ export class ClientFeatureToggleDelta extends EventEmitter {
const baseFeatures = await this.getClientFeatures({ const baseFeatures = await this.getClientFeatures({
environment, environment,
}); });
const baseSegments = await this.segmentReadModel.getAllForClient(); const baseSegments = await this.segmentReadModel.getAllForClientIds();
this.currentRevisionId = this.currentRevisionId =
await this.configurationRevisionService.getMaxRevisionId(); await this.configurationRevisionService.getMaxRevisionId();

2
src/lib/features/segment/fake-segment-read-model.ts
View File

@ -23,7 +23,7 @@ export class FakeSegmentReadModel implements ISegmentReadModel {
return []; return [];
} }
async getAllForClient(ids?: number[]): Promise<IClientSegment[]> { async getAllForClientIds(ids?: number[]): Promise<IClientSegment[]> {
return []; return [];
} }
} }

2
src/lib/features/segment/segment-read-model-type.ts
View File

@ -9,5 +9,5 @@ export interface ISegmentReadModel {
getAllFeatureStrategySegments(): Promise<IFeatureStrategySegment[]>; getAllFeatureStrategySegments(): Promise<IFeatureStrategySegment[]>;
getActive(): Promise<ISegment[]>; getActive(): Promise<ISegment[]>;
getActiveForClient(): Promise<IClientSegment[]>; getActiveForClient(): Promise<IClientSegment[]>;
getAllForClient(ids?: number[]): Promise<IClientSegment[]>; getAllForClientIds(ids?: number[]): Promise<IClientSegment[]>;
} }

6
src/lib/features/segment/segment-read-model.ts
View File

@ -110,7 +110,11 @@ export class SegmentReadModel implements ISegmentReadModel {
})); }));
} }
async getAllForClient(ids?: number[]): Promise<IClientSegment[]> { async getAllForClientIds(ids?: number[]): Promise<IClientSegment[]> {
if (!ids || ids.length === 0) {
return [];
}
const fullSegments = await this.getAll(ids); const fullSegments = await this.getAll(ids);
return fullSegments.map((segments) => ({ return fullSegments.map((segments) => ({