Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-09-05 17:53:12 +02:00
Code Issues Projects Releases Wiki Activity

refactor: remove redundant ADMIN role check

Browse Source
This commit is contained in:
Nuno Góis 2024-06-18 09:03:20 +01:00
parent f791b866dd
commit afbb1b6192
No known key found for this signature in database
GPG Key ID: 71ECC689F1091765
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
frontend/src/component/project/ProjectAccess/ProjectAccessAssign/ProjectAccessAssign.tsx
View File

@ -39,6 +39,7 @@ import type { IServiceAccount } from 'interfaces/service-account';
import { MultipleRoleSelect } from 'component/common/MultipleRoleSelect/MultipleRoleSelect'; import { MultipleRoleSelect } from 'component/common/MultipleRoleSelect/MultipleRoleSelect';
import type { IUserProjectRole } from '../../../../interfaces/userProjectRoles'; import type { IUserProjectRole } from '../../../../interfaces/userProjectRoles';
import { useCheckProjectPermissions } from 'hooks/useHasAccess'; import { useCheckProjectPermissions } from 'hooks/useHasAccess';
import { ADMIN } from 'component/providers/AccessProvider/permissions';
const StyledForm = styled('form')(() => ({ const StyledForm = styled('form')(() => ({
display: 'flex', display: 'flex',
@ -326,12 +327,10 @@ export const ProjectAccessAssign = ({
const isValid = selectedOptions.length > 0 && selectedRoles.length > 0; const isValid = selectedOptions.length > 0 && selectedRoles.length > 0;
const displayAllRoles = const displayAllRoles =
checkPermissions('ADMIN') || checkPermissions(ADMIN) ||
userRoles.length === 0 || userRoles.length === 0 ||
userRoles.some( userRoles.some((userRole) => userRole.name === 'Owner');
(userRole) =>
userRole.name === 'Admin' || userRole.name === 'Owner',
);
let filteredRoles: IRole[]; let filteredRoles: IRole[];
if (displayAllRoles) { if (displayAllRoles) {
filteredRoles = roles; filteredRoles = roles;