Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-11-10 01:19:53 +01:00
Code Issues Projects Releases Wiki Activity

feat: Remove filterFlagsToArchive flag and enable its features permanently

Browse Source
This commit is contained in:
unleash-bot 2025-08-28 13:12:10 +00:00
parent b071b17dd6
commit b045a25e4a
4 changed files with 9 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
frontend/src/component/project/Project/PaginatedProjectFeatureToggles/ProjectFeatureToggles.tsx
View File

@ -55,7 +55,6 @@ import { UPDATE_FEATURE } from '@server/types/permissions';
import { ImportModal } from '../Import/ImportModal.tsx'; import { ImportModal } from '../Import/ImportModal.tsx';
import { IMPORT_BUTTON } from 'utils/testIds'; import { IMPORT_BUTTON } from 'utils/testIds';
import { ProjectCleanupReminder } from './ProjectCleanupReminder/ProjectCleanupReminder.tsx'; import { ProjectCleanupReminder } from './ProjectCleanupReminder/ProjectCleanupReminder.tsx';
import { useUiFlag } from 'hooks/useUiFlag.ts';
interface IPaginatedProjectFeatureTogglesProps { interface IPaginatedProjectFeatureTogglesProps {
environments: string[]; environments: string[];
@ -94,7 +93,6 @@ export const ProjectFeatureToggles = ({
const { project } = useProjectOverview(projectId); const { project } = useProjectOverview(projectId);
const [connectSdkOpen, setConnectSdkOpen] = useState(false); const [connectSdkOpen, setConnectSdkOpen] = useState(false);
const [modalOpen, setModalOpen] = useState(false); const [modalOpen, setModalOpen] = useState(false);
const isFilterFlagsToArchiveEnabled = useUiFlag('filterFlagsToArchive');
const { const {
features, features,
@ -477,9 +475,7 @@ export const ProjectFeatureToggles = ({
const selectedData = useSelectedData(features, rowSelection); const selectedData = useSelectedData(features, rowSelection);
const showCleanupReminder = const showCleanupReminder =
isFilterFlagsToArchiveEnabled && !tableState.lastSeenAt && !tableState.lifecycle;
!tableState.lastSeenAt &&
!tableState.lifecycle;
return ( return (
<Container> <Container>

14
frontend/src/component/project/Project/PaginatedProjectFeatureToggles/ProjectOverviewFilters.tsx
View File

@ -7,7 +7,6 @@ import {
} from 'component/filter/Filters/Filters'; } from 'component/filter/Filters/Filters';
import { useProjectFlagCreators } from 'hooks/api/getters/useProjectFlagCreators/useProjectFlagCreators'; import { useProjectFlagCreators } from 'hooks/api/getters/useProjectFlagCreators/useProjectFlagCreators';
import { formatTag } from 'utils/format-tag'; import { formatTag } from 'utils/format-tag';
import { useUiFlag } from 'hooks/useUiFlag';
interface IProjectOverviewFilters { interface IProjectOverviewFilters {
state: FilterItemParamHolder; state: FilterItemParamHolder;
@ -22,7 +21,6 @@ export const ProjectOverviewFilters: VFC<IProjectOverviewFilters> = ({
}) => { }) => {
const { tags } = useAllTags(); const { tags } = useAllTags();
const { flagCreators } = useProjectFlagCreators(project); const { flagCreators } = useProjectFlagCreators(project);
const filterFlagsToArchiveEnabled = useUiFlag('filterFlagsToArchive');
const [availableFilters, setAvailableFilters] = useState<IFilterItem[]>([]); const [availableFilters, setAvailableFilters] = useState<IFilterItem[]>([]);
useEffect(() => { useEffect(() => {
@ -83,17 +81,13 @@ export const ProjectOverviewFilters: VFC<IProjectOverviewFilters> = ({
filterKey: 'createdAt', filterKey: 'createdAt',
dateOperators: ['IS_ON_OR_AFTER', 'IS_BEFORE'], dateOperators: ['IS_ON_OR_AFTER', 'IS_BEFORE'],
}, },
...(filterFlagsToArchiveEnabled
? [
{ {
label: 'Last seen', label: 'Last seen',
icon: 'monitor_heart', icon: 'monitor_heart',
options: [], options: [],
filterKey: 'lastSeenAt', filterKey: 'lastSeenAt',
dateOperators: ['IS_ON_OR_AFTER', 'IS_BEFORE'], dateOperators: ['IS_ON_OR_AFTER', 'IS_BEFORE'],
} as IFilterItem, },
]
: []),
{ {
label: 'Flag type', label: 'Flag type',
icon: 'flag', icon: 'flag',
@ -140,11 +134,7 @@ export const ProjectOverviewFilters: VFC<IProjectOverviewFilters> = ({
]; ];
setAvailableFilters(availableFilters); setAvailableFilters(availableFilters);
}, [ }, [JSON.stringify(tags), JSON.stringify(flagCreators)]);
JSON.stringify(tags),
JSON.stringify(flagCreators),
filterFlagsToArchiveEnabled,
]);
return ( return (
<Filters <Filters

1
frontend/src/interfaces/uiConfig.ts
View File

@ -90,7 +90,6 @@ export type UiFlags = {
reportUnknownFlags?: boolean; reportUnknownFlags?: boolean;
lifecycleGraphs?: boolean; lifecycleGraphs?: boolean;
addConfiguration?: boolean; addConfiguration?: boolean;
filterFlagsToArchive?: boolean;
}; };
export interface IVersionInfo { export interface IVersionInfo {

5
src/lib/types/experimental.ts
View File

@ -58,7 +58,6 @@ export type IFlagKey =
| 'changeRequestApproverEmails' | 'changeRequestApproverEmails'
| 'lifecycleGraphs' | 'lifecycleGraphs'
| 'addConfiguration' | 'addConfiguration'
| 'filterFlagsToArchive'
| 'fetchMode' | 'fetchMode'
| 'etagByEnv'; | 'etagByEnv';
@ -268,10 +267,6 @@ const flags: IFlags = {
process.env.UNLEASH_EXPERIMENTAL_ADD_CONFIGURATION, process.env.UNLEASH_EXPERIMENTAL_ADD_CONFIGURATION,
false, false,
), ),
filterFlagsToArchive: parseEnvVarBoolean(
process.env.UNLEASH_EXPERIMENTAL_FILTER_FLAGS_TO_ARCHIVE,
false,
),
fetchMode: { fetchMode: {
name: 'disabled', name: 'disabled',
feature_enabled: false, feature_enabled: false,