[Gitar] Cleaning up stale flag: killInsightsUI with value false (#8002)

Co-authored-by: Gitar <noreply@gitar.co>
Co-authored-by: Tymoteusz Czech <2625371+Tymek@users.noreply.github.com>

frontend/src/component/layout/MainLayout/NavigationSidebar/NavigationList.tsx

@@ -20,7 +20,6 @@ import AccordionDetails from '@mui/material/AccordionDetails';
 import AccordionSummary from '@mui/material/AccordionSummary';
 import ExpandMoreIcon from '@mui/icons-material/ExpandMore';
 import FlagIcon from '@mui/icons-material/OutlinedFlag';
-import { useUiFlag } from 'hooks/useUiFlag';
 import { ConditionallyRender } from 'component/common/ConditionallyRender/ConditionallyRender';
 import useProjectOverview from 'hooks/api/getters/useProjectOverview/useProjectOverview';
 import { ProjectIcon } from 'component/common/ProjectIcon/ProjectIcon';
@@ -156,7 +155,6 @@ export const PrimaryNavigationList: FC<{
     activeItem?: string;
 }> = ({ mode, onClick, activeItem }) => {
     const DynamicListItem = mode === 'mini' ? MiniListItem : FullListItem;
-    const killInsightsDashboard = useUiFlag('killInsightsUI');
     const { isOss } = useUiConfig();
 
     return (
@@ -186,7 +184,7 @@ export const PrimaryNavigationList: FC<{
                 <PlaygroundIcon />
             </DynamicListItem>
             <ConditionallyRender
-                condition={!killInsightsDashboard && !isOss()}
+                condition={!isOss()}
                 show={
                     <DynamicListItem
                         href='/insights'

frontend/src/component/menu/Header/OldHeader.tsx

@@ -36,7 +36,6 @@ import { Notifications } from 'component/common/Notifications/Notifications';
 import { useAdminRoutes } from 'component/admin/useAdminRoutes';
 import InviteLinkButton from './InviteLink/InviteLinkButton/InviteLinkButton';
 import { useUiFlag } from 'hooks/useUiFlag';
-import { Badge } from '../../common/Badge/Badge';
 
 const HeaderComponent = styled(AppBar)(({ theme }) => ({
     backgroundColor: theme.palette.background.paper,
@@ -117,23 +116,6 @@ const styledIconProps = (theme: Theme) => ({
 
 const StyledLink = styled(Link)(({ theme }) => focusable(theme));
 
-const StyledText = styled('div')(({ theme }) => ({
-    display: 'flex',
-    alignItems: 'center',
-    gap: theme.spacing(1),
-}));
-
-const StyledLinkWithBetaBadge = ({
-    title,
-    to,
-}: { title: string; to: string }) => (
-    <StyledLink to={to} sx={{ margin: 0 }}>
-        <StyledText>
-            <span>{title}</span> <Badge color='success'>Beta</Badge>
-        </StyledText>
-    </StyledLink>
-);
-
 const StyledIconButton = styled(IconButton)<{
     component?: 'a' | 'button';
     href?: string;
@@ -164,7 +146,6 @@ const OldHeader: VFC = () => {
     const onAdminClose = () => setAdminRef(null);
     const onConfigureClose = () => setConfigRef(null);
     const celebatoryUnleash = useUiFlag('celebrateUnleash');
-    const killInsightsDashboard = useUiFlag('killInsightsUI');
 
     const routes = getRoutes();
     const adminRoutes = useAdminRoutes();
@@ -242,7 +223,7 @@ const OldHeader: VFC = () => {
                         <StyledLink to={'/search'}>Search</StyledLink>
                         <StyledLink to='/playground'>Playground</StyledLink>
                         <ConditionallyRender
-                            condition={!killInsightsDashboard && !isOss()}
+                            condition={!isOss()}
                             show={
                                 <StyledLink to='/insights'>Insights</StyledLink>
                             }

frontend/src/component/menu/__tests__/__snapshots__/routes.test.tsx.snap

@@ -129,7 +129,6 @@ exports[`returns all baseRoutes 1`] = `
     "menu": {
       "mobile": true,
     },
-    "notFlag": "killInsightsUI",
     "path": "/insights",
     "title": "Insights",
     "type": "protected",

frontend/src/component/menu/routes.ts

@@ -151,7 +151,6 @@ export const routes: IRoute[] = [
         component: Insights,
         type: 'protected',
         menu: { mobile: true },
-        notFlag: 'killInsightsUI',
         enterprise: true,
     },
 

frontend/src/interfaces/uiConfig.ts

@@ -72,7 +72,6 @@ export type UiFlags = {
     featureSearchFeedback?: Variant;
     enableLicense?: boolean;
     adminTokenKillSwitch?: boolean;
-    killInsightsUI?: boolean;
     feedbackComments?: Variant;
     displayUpgradeEdgeBanner?: boolean;
     showInactiveUsers?: boolean;

src/lib/__snapshots__/create-config.test.ts.snap

@@ -120,7 +120,6 @@ exports[`should create default config 1`] = `
       },
       "filterInvalidClientMetrics": false,
       "googleAuthEnabled": false,
-      "killInsightsUI": false,
       "killScheduledChangeRequestCache": false,
       "maintenanceMode": false,
       "manyStrategiesPagination": false,

src/lib/types/experimental.ts

@@ -34,7 +34,6 @@ export type IFlagKey =
     | 'edgeBulkMetrics'
     | 'extendedUsageMetrics'
     | 'adminTokenKillSwitch'
-    | 'killInsightsUI'
     | 'feedbackComments'
     | 'showInactiveUsers'
     | 'killScheduledChangeRequestCache'
@@ -182,10 +181,6 @@ const flags: IFlags = {
         process.env.UNLEASH_EXPERIMENTAL_ADMIN_TOKEN_KILL_SWITCH,
         false,
     ),
-    killInsightsUI: parseEnvVarBoolean(
-        process.env.UNLEASH_EXPERIMENTAL_KILL_INSIGHTS_UI,
-        false,
-    ),
     outdatedSdksBanner: parseEnvVarBoolean(
         process.env.UNLEASH_EXPERIMENTAL_OUTDATED_SDKS_BANNER,
         false,

src/server-dev.ts

@@ -43,7 +43,6 @@ process.nextTick(async () => {
                         stripHeadersOnAPI: true,
                         celebrateUnleash: true,
                         featureSearchFeedbackPosting: true,
-                        killInsightsUI: false,
                         userAccessUIEnabled: true,
                         outdatedSdksBanner: true,
                         disableShowContextFieldSelectionValues: false,