Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-02-04 00:18:01 +01:00
Code Issues Projects Releases Wiki Activity

Feat/refactor polling (#8976)

Browse Source 
This PR refactors the method that listens on revision changes:
- Now supports all environments
- Removed unnecessary populate cache method

# Discussion point

In the listen method, should we implement logic to look into which
environments the events touched? By doing this we would:
- Reduce cache size
- Save some memory/CPU if the environment is not initialized in the
cache, because we could skip the DB calls.
This commit is contained in:
Fredrik Strand Oseberg 2024-12-13 10:25:37 +01:00 committed by GitHub
parent 428b0b370b
commit b2cf0e4e6b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 26 additions and 37 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

63
src/lib/features/client-feature-toggles/cache/client-feature-toggle-cache.ts vendored
View File

@ -178,55 +178,44 @@ export class ClientFeatureToggleCache {
private async onUpdateRevisionEvent() {
if (this.flagResolver.isEnabled('deltaApi')) {
await this.pollEvents();
await this.listenToRevisionChange();
}
}
public async pollEvents() {
public async listenToRevisionChange() {
const keys = Object.keys(this.cache);
if (keys.length === 0) return;
const latestRevision =
await this.configurationRevisionService.getMaxRevisionId();
if (this.currentRevisionId === 0) {
await this.populateBaseCache(latestRevision);
} else {
const changeEvents = await this.eventStore.getRevisionRange(
this.currentRevisionId,
latestRevision,
);
const changeEvents = await this.eventStore.getRevisionRange(
this.currentRevisionId,
latestRevision,
);
const changedToggles = [
...new Set(
changeEvents
.filter((event) => event.featureName)
.map((event) => event.featureName!),
),
];
const newToggles = await this.getChangedToggles(
changedToggles,
latestRevision, // TODO: this should come back from the same query to not be out of sync
);
const changedToggles = [
...new Set(
changeEvents
.filter((event) => event.featureName)
.map((event) => event.featureName!),
),
];
const newToggles = await this.getChangedToggles(
changedToggles,
latestRevision, // TODO: this should come back from the same query to not be out of sync
);
if (this.cache.development) {
this.cache.development.addRevision(newToggles);
}
// TODO: Discussion point. Should we filter events by environment and only add revisions in the cache
// for the environment that changed? If we do that we can also save CPU and memory, because we don't need
// to talk to the database if the cache is not initialized for that environment
for (const key of keys) {
this.cache[key].addRevision(newToggles);
}
this.currentRevisionId = latestRevision;
}
private async populateBaseCache(latestRevisionId: number) {
const features = await this.getClientFeatures({
environment: 'development',
});
if (this.cache.development) {
this.cache.development.addRevision({
updated: features as any, //impressionData is not on the type but should be
removed: [],
revisionId: latestRevisionId,
});
}
console.log(`Populated base cache with ${features.length} features`);
}
async getChangedToggles(
toggles: string[],
revisionId: number,