Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-10-27 11:02:16 +01:00
Code Issues Projects Releases Wiki Activity

fix: should allow revive toggles

Browse Source
This commit is contained in:
Ivar Conradi Østhus 2021-04-23 13:29:24 +02:00
parent d021f4ebc5
commit b406d3c7cf
No known key found for this signature in database
GPG Key ID: 31AC596886B0BD09
3 changed files with 17 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/lib/db/feature-toggle-store.js
View File

@ -103,7 +103,11 @@ class FeatureToggleStore {
.first(['project'])
.from(TABLE)
.where({ name })
.then(r => (r ? r.project : undefined));
.then(r => (r ? r.project : undefined))
.catch(e => {
this.logger.error(e);
return undefined;
});
}
async hasFeature(name) {

9
src/lib/routes/admin-api/archive.ts
View File

@ -21,7 +21,11 @@ export default class ArchiveController extends Controller {
this.featureService = featureToggleService;
this.get('/features', this.getArchivedFeatures);
this.post('/revive/:name', this.reviveFeatureToggle, UPDATE_FEATURE);
this.post(
'/revive/:featureName',
this.reviveFeatureToggle,
UPDATE_FEATURE,
);
}
// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
@ -37,9 +41,10 @@ export default class ArchiveController extends Controller {
// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
async reviveFeatureToggle(req, res): Promise<void> {
const userName = extractUser(req);
const { featureName } = req.params;
try {
await this.featureService.reviveToggle(req.params.name, userName);
await this.featureService.reviveToggle(featureName, userName);
return res.status(200).end();
} catch (error) {
this.logger.error('Server failed executing request', error);

5
src/test/e2e/stores/feature-toggle-store.e2e.test.js
View File

@ -24,3 +24,8 @@ test.serial('should not crash for unknown toggle', async t => {
);
t.is(project, undefined);
});
test.serial('should not crash for undefined toggle name', async t => {
const project = await featureToggleStore.getProjectId(undefined);
t.is(project, undefined);
});