mirror of
https://github.com/Unleash/unleash.git
synced 2025-02-23 00:22:19 +01:00
fix: should allow revive toggles
This commit is contained in:
parent
d021f4ebc5
commit
b406d3c7cf
@ -103,7 +103,11 @@ class FeatureToggleStore {
|
|||||||
.first(['project'])
|
.first(['project'])
|
||||||
.from(TABLE)
|
.from(TABLE)
|
||||||
.where({ name })
|
.where({ name })
|
||||||
.then(r => (r ? r.project : undefined));
|
.then(r => (r ? r.project : undefined))
|
||||||
|
.catch(e => {
|
||||||
|
this.logger.error(e);
|
||||||
|
return undefined;
|
||||||
|
});
|
||||||
}
|
}
|
||||||
|
|
||||||
async hasFeature(name) {
|
async hasFeature(name) {
|
||||||
|
@ -21,7 +21,11 @@ export default class ArchiveController extends Controller {
|
|||||||
this.featureService = featureToggleService;
|
this.featureService = featureToggleService;
|
||||||
|
|
||||||
this.get('/features', this.getArchivedFeatures);
|
this.get('/features', this.getArchivedFeatures);
|
||||||
this.post('/revive/:name', this.reviveFeatureToggle, UPDATE_FEATURE);
|
this.post(
|
||||||
|
'/revive/:featureName',
|
||||||
|
this.reviveFeatureToggle,
|
||||||
|
UPDATE_FEATURE,
|
||||||
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
|
// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
|
||||||
@ -37,9 +41,10 @@ export default class ArchiveController extends Controller {
|
|||||||
// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
|
// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
|
||||||
async reviveFeatureToggle(req, res): Promise<void> {
|
async reviveFeatureToggle(req, res): Promise<void> {
|
||||||
const userName = extractUser(req);
|
const userName = extractUser(req);
|
||||||
|
const { featureName } = req.params;
|
||||||
|
|
||||||
try {
|
try {
|
||||||
await this.featureService.reviveToggle(req.params.name, userName);
|
await this.featureService.reviveToggle(featureName, userName);
|
||||||
return res.status(200).end();
|
return res.status(200).end();
|
||||||
} catch (error) {
|
} catch (error) {
|
||||||
this.logger.error('Server failed executing request', error);
|
this.logger.error('Server failed executing request', error);
|
||||||
|
@ -24,3 +24,8 @@ test.serial('should not crash for unknown toggle', async t => {
|
|||||||
);
|
);
|
||||||
t.is(project, undefined);
|
t.is(project, undefined);
|
||||||
});
|
});
|
||||||
|
|
||||||
|
test.serial('should not crash for undefined toggle name', async t => {
|
||||||
|
const project = await featureToggleStore.getProjectId(undefined);
|
||||||
|
t.is(project, undefined);
|
||||||
|
});
|
||||||
|
Loading…
Reference in New Issue
Block a user