Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-07-12 13:48:35 +02:00
Code Issues Projects Releases Wiki Activity

fix: input fields (PR #1110 from NickMolloy/improve-input-attributes)

Browse Source 
* Use correct input type

"string" is not a valid input type: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input#input_types
"text" is the actual valid value.

* Use correct autocomplete values for credential fields
"true", "on", and "confirm-password" are not valid autocomplete values https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/autocomplete
This commit is contained in:
Nick 2022-06-22 21:05:03 +12:00 committed by GitHub
parent 797cd8c28f
commit b4197e54e6
4 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
frontend/src/component/user/HostedAuth/HostedAuth.tsx
View File

@ -113,7 +113,7 @@ const HostedAuth: VFC<IHostedAuthProps> = ({ authDetails, redirect }) => {
label="Username or email" label="Username or email"
name="username" name="username"
id="username" id="username"
type="string" type="text"
onChange={evt => setUsername(evt.target.value)} onChange={evt => setUsername(evt.target.value)}
value={username} value={username}
error={Boolean(usernameError)} error={Boolean(usernameError)}
@ -130,6 +130,7 @@ const HostedAuth: VFC<IHostedAuthProps> = ({ authDetails, redirect }) => {
value={password} value={password}
error={Boolean(passwordError)} error={Boolean(passwordError)}
helperText={passwordError} helperText={passwordError}
autoComplete="current-password"
data-testid={LOGIN_PASSWORD_ID} data-testid={LOGIN_PASSWORD_ID}
/> />
<Grid container> <Grid container>

6
frontend/src/component/user/PasswordAuth/PasswordAuth.tsx
View File

@ -117,12 +117,12 @@ const PasswordAuth: VFC<IPasswordAuthProps> = ({ authDetails, redirect }) => {
label="Username or email" label="Username or email"
name="username" name="username"
id="username" id="username"
type="string" type="text"
onChange={evt => setUsername(evt.target.value)} onChange={evt => setUsername(evt.target.value)}
value={username} value={username}
error={Boolean(usernameError)} error={Boolean(usernameError)}
helperText={usernameError} helperText={usernameError}
autoComplete="true" autoComplete="username"
data-testid={LOGIN_EMAIL_ID} data-testid={LOGIN_EMAIL_ID}
variant="outlined" variant="outlined"
size="small" size="small"
@ -136,7 +136,7 @@ const PasswordAuth: VFC<IPasswordAuthProps> = ({ authDetails, redirect }) => {
value={password} value={password}
error={Boolean(passwordError)} error={Boolean(passwordError)}
helperText={passwordError} helperText={passwordError}
autoComplete="true" autoComplete="current-password"
data-testid={LOGIN_PASSWORD_ID} data-testid={LOGIN_PASSWORD_ID}
/> />
<Button <Button

4
frontend/src/component/user/UserProfile/EditProfile/EditProfile.tsx
View File

@ -115,7 +115,7 @@ const EditProfile = ({
label="Password" label="Password"
name="password" name="password"
value={password} value={password}
autoComplete="on" autoComplete="new-password"
onChange={(e: React.ChangeEvent<HTMLInputElement>) => onChange={(e: React.ChangeEvent<HTMLInputElement>) =>
setPassword(e.target.value) setPassword(e.target.value)
} }
@ -125,7 +125,7 @@ const EditProfile = ({
label="Confirm password" label="Confirm password"
name="confirmPassword" name="confirmPassword"
value={confirmPassword} value={confirmPassword}
autoComplete="on" autoComplete="new-password"
onChange={(e: React.ChangeEvent<HTMLInputElement>) => onChange={(e: React.ChangeEvent<HTMLInputElement>) =>
setConfirmPassword(e.target.value) setConfirmPassword(e.target.value)
} }

4
frontend/src/component/user/common/ResetPasswordForm/ResetPasswordForm.tsx
View File

@ -115,7 +115,7 @@ const ResetPasswordForm = ({ token, setLoading }: IResetPasswordProps) => {
setPassword(e.target.value) setPassword(e.target.value)
} }
onFocus={() => setShowPasswordChecker(true)} onFocus={() => setShowPasswordChecker(true)}
autoComplete="password" autoComplete="new-password"
data-loading data-loading
/> />
<PasswordField <PasswordField
@ -124,7 +124,7 @@ const ResetPasswordForm = ({ token, setLoading }: IResetPasswordProps) => {
onChange={(e: React.ChangeEvent<HTMLInputElement>) => onChange={(e: React.ChangeEvent<HTMLInputElement>) =>
setConfirmPassword(e.target.value) setConfirmPassword(e.target.value)
} }
autoComplete="confirm-password" autoComplete="new-password"
data-loading data-loading
/> />
<ConditionallyRender <ConditionallyRender