1
0
mirror of https://github.com/Unleash/unleash.git synced 2025-09-24 17:51:14 +02:00

chore: adjust add strategy modal height (#10677)

https://linear.app/unleash/issue/2-3893/set-a-minimum-height-in-the-release-template-preview-dialog

Adjusts the "add strategy" and "release template preview" modal heights,
ensuring better visual consistency between them.
This commit is contained in:
Nuno Góis 2025-09-23 16:25:51 +01:00 committed by GitHub
parent 907727947a
commit b4ad9c964f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 39 additions and 25 deletions

View File

@ -248,6 +248,7 @@ export const FeatureStrategyMenu = ({
PaperProps={{ PaperProps={{
sx: { sx: {
borderRadius: '12px', borderRadius: '12px',
height: newStrategyModalEnabled ? '100%' : 'auto',
}, },
}} }}
> >

View File

@ -45,7 +45,7 @@ const StyledContainer = styled(Box)(() => ({
const StyledScrollableContent = styled(Box)(({ theme }) => ({ const StyledScrollableContent = styled(Box)(({ theme }) => ({
width: theme.breakpoints.values.md, width: theme.breakpoints.values.md,
height: theme.spacing(52), height: '100%',
overflowY: 'auto', overflowY: 'auto',
padding: theme.spacing(4), padding: theme.spacing(4),
paddingTop: theme.spacing(2), paddingTop: theme.spacing(2),

View File

@ -19,10 +19,18 @@ import CloseIcon from '@mui/icons-material/Close';
const StyledDialog = styled(Dialog)(({ theme }) => ({ const StyledDialog = styled(Dialog)(({ theme }) => ({
'& .MuiDialog-paper': { '& .MuiDialog-paper': {
borderRadius: theme.shape.borderRadiusLarge, borderRadius: theme.shape.borderRadiusLarge,
width: theme.breakpoints.values.md, height: '100%',
}, },
})); }));
const StyledScrollableContent = styled(Box)(({ theme }) => ({
width: theme.breakpoints.values.md,
height: '100%',
overflowY: 'auto',
display: 'flex',
flexDirection: 'column',
}));
const StyledHeader = styled(Box)(({ theme }) => ({ const StyledHeader = styled(Box)(({ theme }) => ({
display: 'flex', display: 'flex',
justifyContent: 'space-between', justifyContent: 'space-between',
@ -104,14 +112,18 @@ export const ReleasePlanReviewDialog = ({
Go back Go back
</Button> </Button>
</StyledSubHeader> </StyledSubHeader>
<StyledScrollableContent>
{activeReleasePlan && ( {activeReleasePlan && (
<Box sx={{ px: 4, pb: 2 }}> <Box sx={{ px: 4, pb: 2 }}>
<Alert severity='error'> <Alert severity='error'>
This feature environment currently has{' '} This feature environment currently has{' '}
<strong>{activeReleasePlan.name}</strong> -{' '} <strong>{activeReleasePlan.name}</strong> -{' '}
<strong>{activeReleasePlan.milestones[0].name}</strong> <strong>
{environmentEnabled ? ' running' : ' paused'}. Adding a {activeReleasePlan.milestones[0].name}
new release plan will replace the existing release plan. </strong>
{environmentEnabled ? ' running' : ' paused'}.
Adding a new release plan will replace the existing
release plan.
</Alert> </Alert>
</Box> </Box>
)} )}
@ -128,6 +140,7 @@ export const ReleasePlanReviewDialog = ({
</Typography> </Typography>
</Box> </Box>
)} )}
</StyledScrollableContent>
<StyledDialogActions> <StyledDialogActions>
<Button variant='contained' color='primary' onClick={onConfirm}> <Button variant='contained' color='primary' onClick={onConfirm}>
{crProtected ? 'Add suggestion to draft' : 'Apply template'} {crProtected ? 'Add suggestion to draft' : 'Apply template'}