Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-09-24 17:51:14 +02:00
Code Issues Projects Releases Wiki Activity

chore: adjust add strategy modal height (#10677)

Browse Source 
https://linear.app/unleash/issue/2-3893/set-a-minimum-height-in-the-release-template-preview-dialog

Adjusts the "add strategy" and "release template preview" modal heights,
ensuring better visual consistency between them.
This commit is contained in:
Nuno Góis 2025-09-23 16:25:51 +01:00 committed by GitHub
parent 907727947a
commit b4ad9c964f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 39 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
frontend/src/component/feature/FeatureStrategy/FeatureStrategyMenu/FeatureStrategyMenu.tsx
View File

@ -248,6 +248,7 @@ export const FeatureStrategyMenu = ({
PaperProps={{ PaperProps={{
sx: { sx: {
borderRadius: '12px', borderRadius: '12px',
height: newStrategyModalEnabled ? '100%' : 'auto',
}, },
}} }}
> >

2
frontend/src/component/feature/FeatureStrategy/FeatureStrategyMenu/FeatureStrategyMenuCards/FeatureStrategyMenuCards.tsx
View File

@ -45,7 +45,7 @@ const StyledContainer = styled(Box)(() => ({
const StyledScrollableContent = styled(Box)(({ theme }) => ({ const StyledScrollableContent = styled(Box)(({ theme }) => ({
width: theme.breakpoints.values.md, width: theme.breakpoints.values.md,
height: theme.spacing(52), height: '100%',
overflowY: 'auto', overflowY: 'auto',
padding: theme.spacing(4), padding: theme.spacing(4),
paddingTop: theme.spacing(2), paddingTop: theme.spacing(2),

61
frontend/src/component/feature/FeatureView/FeatureOverview/ReleasePlan/ReleasePlanReviewDialog.tsx
View File

@ -19,10 +19,18 @@ import CloseIcon from '@mui/icons-material/Close';
const StyledDialog = styled(Dialog)(({ theme }) => ({ const StyledDialog = styled(Dialog)(({ theme }) => ({
'& .MuiDialog-paper': { '& .MuiDialog-paper': {
borderRadius: theme.shape.borderRadiusLarge, borderRadius: theme.shape.borderRadiusLarge,
width: theme.breakpoints.values.md, height: '100%',
}, },
})); }));
const StyledScrollableContent = styled(Box)(({ theme }) => ({
width: theme.breakpoints.values.md,
height: '100%',
overflowY: 'auto',
display: 'flex',
flexDirection: 'column',
}));
const StyledHeader = styled(Box)(({ theme }) => ({ const StyledHeader = styled(Box)(({ theme }) => ({
display: 'flex', display: 'flex',
justifyContent: 'space-between', justifyContent: 'space-between',
@ -104,30 +112,35 @@ export const ReleasePlanReviewDialog = ({
Go back Go back
</Button> </Button>
</StyledSubHeader> </StyledSubHeader>
{activeReleasePlan && ( <StyledScrollableContent>
<Box sx={{ px: 4, pb: 2 }}> {activeReleasePlan && (
<Alert severity='error'> <Box sx={{ px: 4, pb: 2 }}>
This feature environment currently has{' '} <Alert severity='error'>
<strong>{activeReleasePlan.name}</strong> -{' '} This feature environment currently has{' '}
<strong>{activeReleasePlan.milestones[0].name}</strong> <strong>{activeReleasePlan.name}</strong> -{' '}
{environmentEnabled ? ' running' : ' paused'}. Adding a <strong>
new release plan will replace the existing release plan. {activeReleasePlan.milestones[0].name}
</Alert> </strong>
{environmentEnabled ? ' running' : ' paused'}.
Adding a new release plan will replace the existing
release plan.
</Alert>
</Box>
)}
<Box sx={{ px: 2 }}>
<ReleasePlan plan={planPreview} readonly />
</Box> </Box>
)} {crProtected && (
<Box sx={{ px: 2 }}> <Box sx={{ px: 4, pt: 1 }}>
<ReleasePlan plan={planPreview} readonly /> <Typography>
</Box> <strong>Adding</strong> release template{' '}
{crProtected && ( <strong>{template?.name}</strong> to{' '}
<Box sx={{ px: 4, pt: 1 }}> <strong>{featureName}</strong> in{' '}
<Typography> <strong>{environment}</strong>.
<strong>Adding</strong> release template{' '} </Typography>
<strong>{template?.name}</strong> to{' '} </Box>
<strong>{featureName}</strong> in{' '} )}
<strong>{environment}</strong>. </StyledScrollableContent>
</Typography>
</Box>
)}
<StyledDialogActions> <StyledDialogActions>
<Button variant='contained' color='primary' onClick={onConfirm}> <Button variant='contained' color='primary' onClick={onConfirm}>
{crProtected ? 'Add suggestion to draft' : 'Apply template'} {crProtected ? 'Add suggestion to draft' : 'Apply template'}