Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-09-10 17:53:36 +02:00
Code Issues Projects Releases Wiki Activity

refactor: separate fake admin and client store

Browse Source
This commit is contained in:
kwasniew 2023-03-09 11:18:34 +01:00
parent 7a7c71f095
commit b4d1bd8059
No known key found for this signature in database
GPG Key ID: 43A7CBC24C119560
3 changed files with 5 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/lib/features/feature-toggle/createFeatureToggleService.ts
View File

@ -35,6 +35,7 @@ import FakeRoleStore from '../../../test/fixtures/fake-role-store';
import FakeEnvironmentStore from '../../../test/fixtures/fake-environment-store'; import FakeEnvironmentStore from '../../../test/fixtures/fake-environment-store';
import EventStore from '../../db/event-store'; import EventStore from '../../db/event-store';
import FeatureToggleAdminStore from '../../db/feature-toggle-admin-store'; import FeatureToggleAdminStore from '../../db/feature-toggle-admin-store';
import FakeFeatureToggleAdminStore from '../../../test/fixtures/fake-feature-toggle-admin-store';
export const createFeatureToggleService = ( export const createFeatureToggleService = (
db: Db, db: Db,
@ -118,7 +119,7 @@ export const createFakeFeatureToggleService = (
const featureStrategiesStore = new FakeFeatureStrategiesStore(); const featureStrategiesStore = new FakeFeatureStrategiesStore();
const featureToggleStore = new FakeFeatureToggleStore(); const featureToggleStore = new FakeFeatureToggleStore();
const featureToggleClientStore = new FakeFeatureToggleClientStore(); const featureToggleClientStore = new FakeFeatureToggleClientStore();
const featureToggleAdminStore = new FakeFeatureToggleClientStore(); const featureToggleAdminStore = new FakeFeatureToggleAdminStore();
const projectStore = new FakeProjectStore(); const projectStore = new FakeProjectStore();
const featureTagStore = new FakeFeatureTagStore(); const featureTagStore = new FakeFeatureTagStore();
const featureEnvironmentStore = new FakeFeatureEnvironmentStore(); const featureEnvironmentStore = new FakeFeatureEnvironmentStore();

11
src/test/fixtures/fake-feature-toggle-client-store.ts vendored
View File

@ -4,11 +4,9 @@ import {
IFeatureToggleQuery, IFeatureToggleQuery,
} from '../../lib/types/model'; } from '../../lib/types/model';
import { IFeatureToggleClientStore } from '../../lib/types/stores/feature-toggle-client-store'; import { IFeatureToggleClientStore } from '../../lib/types/stores/feature-toggle-client-store';
import { IGetAdminFeatures } from '../../lib/db/feature-toggle-client-store';
import { IFeatureToggleAdminStore } from '../../lib/types/stores/feature-toggle-admin-store';
export default class FakeFeatureToggleClientStore export default class FakeFeatureToggleClientStore
implements IFeatureToggleClientStore, IFeatureToggleAdminStore implements IFeatureToggleClientStore
{ {
featureToggles: FeatureToggle[] = []; featureToggles: FeatureToggle[] = [];
@ -54,13 +52,6 @@ export default class FakeFeatureToggleClientStore
return this.getFeatures(query); return this.getFeatures(query);
} }
async getAdmin({
featureQuery: query,
archived,
}: IGetAdminFeatures): Promise<FeatureToggle[]> {
return this.getFeatures(query, archived);
}
// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types // eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
async createFeature(feature: any): Promise<void> { async createFeature(feature: any): Promise<void> {
this.featureToggles.push({ this.featureToggles.push({

3
src/test/fixtures/store.ts vendored
View File

@ -33,6 +33,7 @@ import FakeFavoriteFeaturesStore from './fake-favorite-features-store';
import FakeFavoriteProjectsStore from './fake-favorite-projects-store'; import FakeFavoriteProjectsStore from './fake-favorite-projects-store';
import { FakeAccountStore } from './fake-account-store'; import { FakeAccountStore } from './fake-account-store';
import FakeProjectStatsStore from './fake-project-stats-store'; import FakeProjectStatsStore from './fake-project-stats-store';
import FakeFeatureToggleAdminStore from './fake-feature-toggle-admin-store';
const db = { const db = {
select: () => ({ select: () => ({
@ -48,7 +49,7 @@ const createStores: () => IUnleashStores = () => {
clientInstanceStore: new FakeClientInstanceStore(), clientInstanceStore: new FakeClientInstanceStore(),
featureToggleStore: new FakeFeatureToggleStore(), featureToggleStore: new FakeFeatureToggleStore(),
featureToggleClientStore: new FakeFeatureToggleClientStore(), featureToggleClientStore: new FakeFeatureToggleClientStore(),
featureToggleAdminStore: new FakeFeatureToggleClientStore(), featureToggleAdminStore: new FakeFeatureToggleAdminStore(),
tagStore: new FakeTagStore(), tagStore: new FakeTagStore(),
tagTypeStore: new FakeTagTypeStore(), tagTypeStore: new FakeTagTypeStore(),
eventStore: new FakeEventStore(), eventStore: new FakeEventStore(),