Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-01-25 00:07:47 +01:00
Code Issues Projects Releases Wiki Activity

chore: wait to input the name of the segment when checking for error messages (#7377)

Browse Source 
This change adds a wait statement before entering the name of the
segment when checking for error messages that this segment name
already exists.

This is the same workaround that we did in
https://github.com/Unleash/unleash/pull/7289, which seems to have
worked.

Like in that PR, using waits is still an antipattern, but it appears
to be working.

Maybe it’s time to look more deeply at why it happens? Why isn’t the
field ready to receive input even though it’s on the page? Is it mui’s
fault or ours?
This commit is contained in:
Thomas Heartman 2024-06-12 14:06:44 +02:00 committed by GitHub
parent 557c499ff5
commit b5de65bb8e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
frontend/cypress/integration/segments/segments.spec.ts
View File

@ -24,6 +24,7 @@ describe('segments', () => {
it('gives an error if a segment exists with the same name', () => {
cy.get("[data-testid='NAVIGATE_TO_CREATE_SEGMENT']").click();
cy.wait(500);
cy.get("[data-testid='SEGMENT_NAME_ID']").type(segmentName);
cy.get("[data-testid='SEGMENT_NEXT_BTN_ID']").should('be.disabled');
cy.get("[data-testid='INPUT_ERROR_TEXT']").contains(