Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-08-13 13:48:59 +02:00
Code Issues Projects Releases Wiki Activity

fix test

Browse Source 
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
This commit is contained in:
andreas-unleash 2024-03-21 10:14:04 +02:00
parent 46a1a962b3
commit b72bea786e
No known key found for this signature in database
GPG Key ID: 86EF87A739B39099
2 changed files with 112 additions and 95 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
frontend/src/component/executiveDashboard/hooks/useFilteredFlagsSummary.test.ts
View File

@ -1,10 +1,12 @@
import { renderHook } from '@testing-library/react-hooks';
import { useFilteredFlagsSummary } from './useFilteredFlagsSummary';
import type { ExecutiveSummarySchemaUsers } from '../../../openapi';
describe('useFilteredFlagTrends', () => {
it('should summarize only last week of project flag trends', () => {
const { result } = renderHook(() =>
useFilteredFlagsSummary([
useFilteredFlagsSummary(
[
{
week: '2024-01',
project: 'project1',
@ -45,7 +47,9 @@ describe('useFilteredFlagTrends', () => {
users: 3,
date: '',
},
]),
],
{ total: 1 } as unknown as ExecutiveSummarySchemaUsers,
),
);
expect(result.current).toEqual({
@ -55,12 +59,14 @@ describe('useFilteredFlagTrends', () => {
potentiallyStale: 1,
averageUsers: 2,
averageHealth: '79',
flagsPerUser: '14.0',
});
});
it('should work with project with zero users', () => {
const { result, rerender } = renderHook(() =>
useFilteredFlagsSummary([
useFilteredFlagsSummary(
[
{
week: '2024-01',
project: 'project1',
@ -71,7 +77,9 @@ describe('useFilteredFlagTrends', () => {
users: 0,
date: '',
},
]),
],
{ total: 1 } as unknown as ExecutiveSummarySchemaUsers,
),
);
expect(result.current).toEqual({
@ -81,12 +89,14 @@ describe('useFilteredFlagTrends', () => {
potentiallyStale: 0,
averageUsers: 0,
averageHealth: '100',
flagsPerUser: '5.0',
});
});
it('should work with projects where some have with zero users', () => {
const { result } = renderHook(() =>
useFilteredFlagsSummary([
useFilteredFlagsSummary(
[
{
week: '2024-01',
project: 'project1',
@ -107,7 +117,9 @@ describe('useFilteredFlagTrends', () => {
users: 3,
date: '',
},
]),
],
{ total: 1 } as unknown as ExecutiveSummarySchemaUsers,
),
);
expect(result.current).toEqual({
@ -117,12 +129,14 @@ describe('useFilteredFlagTrends', () => {
potentiallyStale: 0,
averageUsers: 1.5,
averageHealth: '100',
flagsPerUser: '10.0',
});
});
it('should set health of a project without feature toggles to undefined', () => {
const { result } = renderHook(() =>
useFilteredFlagsSummary([
useFilteredFlagsSummary(
[
{
week: '2024-01',
project: 'project1',
@ -133,7 +147,9 @@ describe('useFilteredFlagTrends', () => {
users: 0,
date: '',
},
]),
],
{ total: 1 } as unknown as ExecutiveSummarySchemaUsers,
),
);
expect(result.current).toEqual({
@ -143,6 +159,7 @@ describe('useFilteredFlagTrends', () => {
potentiallyStale: 0,
averageUsers: 0,
averageHealth: undefined,
flagsPerUser: 'N/A',
});
});
});

12
frontend/src/component/executiveDashboard/hooks/useFilteredFlagsSummary.ts
View File

@ -1,13 +1,13 @@
import { useMemo } from 'react';
import type {
ExecutiveSummarySchema,
ExecutiveSummarySchemaProjectFlagTrendsItem,
ExecutiveSummarySchemaUsers,
} from 'openapi';
// NOTE: should we move project filtering to the backend?
export const useFilteredFlagsSummary = (
filteredProjectFlagTrends: ExecutiveSummarySchemaProjectFlagTrendsItem[],
users: ExecutiveSummarySchema['users'],
users: ExecutiveSummarySchemaUsers,
) =>
useMemo(() => {
const lastWeekId = filteredProjectFlagTrends.reduce((prev, current) => {
@ -42,14 +42,14 @@ export const useFilteredFlagsSummary = (
},
);
const flagsPerUser =
sum.total && users?.total ? sum.total / users.total : 0;
const flagsPerUser = users?.total ? sum.total / users.total : 0;
return {
...sum,
flagsPerUser: Number.isNaN(flagsPerUser)
flagsPerUser:
Number.isNaN(flagsPerUser) || flagsPerUser === 0
? 'N/A'
: flagsPerUser.toFixed(2),
: flagsPerUser.toFixed(1),
averageUsers,
averageHealth: sum.total
? ((sum.active / (sum.total || 1)) * 100).toFixed(0)