From b7cea5e31491bc3a4a6524e4a24094080ef17e60 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ivar=20Conradi=20=C3=98sthus?= Date: Wed, 5 May 2021 22:06:55 +0200 Subject: [PATCH] fix: should be allowed to create toggles without errors --- .../src/component/feature/create/CreateFeature/index.jsx | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/frontend/src/component/feature/create/CreateFeature/index.jsx b/frontend/src/component/feature/create/CreateFeature/index.jsx index 95e76e5909..fb2fbc7ffa 100644 --- a/frontend/src/component/feature/create/CreateFeature/index.jsx +++ b/frontend/src/component/feature/create/CreateFeature/index.jsx @@ -50,7 +50,7 @@ class WrapperComponent extends Component { }; validateName = async featureToggleName => { - const { errors } = this.state; + const { errors } = {...this.state}; try { await validateName(featureToggleName); errors.name = undefined; @@ -66,7 +66,9 @@ class WrapperComponent extends Component { const { createFeatureToggles, history } = this.props; const { featureToggle } = this.state; - if (Object.keys(this.state.errors)) { + const errors = Object.values(this.state.errors).filter(i => i); + + if (errors.length > 0) { return; } @@ -74,6 +76,7 @@ class WrapperComponent extends Component { featureToggle.strategies = [defaultStrategy]; } + createFeatureToggles(featureToggle).then(() => history.push(`/features/strategies/${featureToggle.name}`) );