From b93968a17bcfbdc1bceda74f2f7f6985a03ba06a Mon Sep 17 00:00:00 2001 From: kwasniew Date: Wed, 24 Sep 2025 10:42:38 +0200 Subject: [PATCH] feat: histogram impact metric UI --- .../ImpactMetricsControls/ImpactMetricsControls.tsx | 2 +- .../ModeSelector/ModeSelector.tsx | 12 ++++++------ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/frontend/src/component/impact-metrics/ChartConfigModal/ImpactMetricsControls/ImpactMetricsControls.tsx b/frontend/src/component/impact-metrics/ChartConfigModal/ImpactMetricsControls/ImpactMetricsControls.tsx index 432295cb58..1ab8cfad6b 100644 --- a/frontend/src/component/impact-metrics/ChartConfigModal/ImpactMetricsControls/ImpactMetricsControls.tsx +++ b/frontend/src/component/impact-metrics/ChartConfigModal/ImpactMetricsControls/ImpactMetricsControls.tsx @@ -58,7 +58,7 @@ export const ImpactMetricsControls: FC = ({ ) : null} diff --git a/frontend/src/component/impact-metrics/ChartConfigModal/ImpactMetricsControls/ModeSelector/ModeSelector.tsx b/frontend/src/component/impact-metrics/ChartConfigModal/ImpactMetricsControls/ModeSelector/ModeSelector.tsx index fa06d18f12..c603332797 100644 --- a/frontend/src/component/impact-metrics/ChartConfigModal/ImpactMetricsControls/ModeSelector/ModeSelector.tsx +++ b/frontend/src/component/impact-metrics/ChartConfigModal/ImpactMetricsControls/ModeSelector/ModeSelector.tsx @@ -5,15 +5,15 @@ import type { AggregationMode } from '../../../types.ts'; export type ModeSelectorProps = { value: AggregationMode; onChange: (mode: AggregationMode) => void; - seriesType: 'counter' | 'gauge' | 'histogram' | 'unknown'; + metricType: 'counter' | 'gauge' | 'histogram' | 'unknown'; }; export const ModeSelector: FC = ({ value, onChange, - seriesType, + metricType, }) => { - if (seriesType === 'unknown') return null; + if (metricType === 'unknown') return null; return ( Mode @@ -23,7 +23,7 @@ export const ModeSelector: FC = ({ onChange={(e) => onChange(e.target.value as AggregationMode)} label='Mode' > - {seriesType === 'counter' + {metricType === 'counter' ? [ Rate per second @@ -32,7 +32,7 @@ export const ModeSelector: FC = ({ Count , ] - : seriesType === 'gauge' + : metricType === 'gauge' ? [ Average @@ -41,7 +41,7 @@ export const ModeSelector: FC = ({ Sum , ] - : seriesType === 'histogram' + : metricType === 'histogram' ? [ 50th percentile