Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-06-14 01:16:17 +02:00
Code Issues Projects Releases Wiki Activity

Fix failing tests

Browse Source
This commit is contained in:
ivaosthu 2016-12-12 17:09:44 +01:00 committed by Ivar Conradi Østhus
parent 7d91f4c1d5
commit ba5810506f
3 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/db/strategy-store.js
View File

@ -3,7 +3,7 @@
const { STRATEGY_CREATED, STRATEGY_DELETED } = require('../event-type'); const { STRATEGY_CREATED, STRATEGY_DELETED } = require('../event-type');
const logger = require('../logger'); const logger = require('../logger');
const NotFoundError = require('../error/notfound-error'); const NotFoundError = require('../error/notfound-error');
const STRATEGY_COLUMNS = ['name', 'description', 'parameters_template']; const STRATEGY_COLUMNS = ['name', 'description', 'parameters'];
const TABLE = 'strategies'; const TABLE = 'strategies';
class StrategyStore { class StrategyStore {
@ -44,7 +44,7 @@ class StrategyStore {
return { return {
name: row.name, name: row.name,
description: row.description, description: row.description,
parametersTemplate: row.parameters_template, parameters: row.parameters,
}; };
} }
@ -52,7 +52,7 @@ class StrategyStore {
return { return {
name: data.name, name: data.name,
description: data.description, description: data.description,
parameters_template: data.parametersTemplate // eslint-disable-line parameters: JSON.stringify(data.parameters),
}; };
} }

8
test/e2e/helpers/test-helper.js
View File

@ -48,14 +48,14 @@ function createStrategies (stores) {
{ {
name: 'default', name: 'default',
description: 'Default on or off Strategy.', description: 'Default on or off Strategy.',
parametersTemplate: {}, parameters: [],
}, },
{ {
name: 'usersWithEmail', name: 'usersWithEmail',
description: 'Active for users defined in the comma-separated emails-parameter.', description: 'Active for users defined in the comma-separated emails-parameter.',
parametersTemplate: { parameters: [
emails: 'String', { name: 'emails', type: 'string' },
}, ],
}, },
].map(strategy => stores.strategyStore._createStrategy(strategy)); ].map(strategy => stores.strategyStore._createStrategy(strategy));
} }

3
test/e2e/strategy-api.test.js
View File

@ -14,6 +14,9 @@ test.serial('gets all strategies', async (t) => {
.get('/api/strategies') .get('/api/strategies')
.expect('Content-Type', /json/) .expect('Content-Type', /json/)
.expect(200) .expect(200)
.expect((res) => {
t.true(res.body.strategies.length === 2, 'expected to have two strategies');
})
.then(destroy); .then(destroy);
}); });